X509 test vector #99
Merged
X509 test vector #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.4.1
Changes as an effect of changing persistent storage model.
Release 1.5.1
Support for attributes that may appear in calls to the load method.
We need only one x5t calculator.
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 77.51% 77.54% +0.02%
==========================================
Files 41 41
Lines 4346 4342 -4
Branches 841 841
==========================================
- Hits 3369 3367 -2
+ Misses 712 711 -1
+ Partials 265 264 -1
Continue to review full report at Codecov.
|
jschlyter
approved these changes
Nov 2, 2021
|
Looking good, but there are still broken certs. #98 updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old vectors where broken. Built a couple of new JWKs with x5c and x5t included.
We had 2 functions for calculating x5t, we only need one.