bugfix: domain name validation.

pyproject.toml

@@ -49,6 +49,7 @@ pytz = "*"
 requests = "^2"
 xmlschema = "^2"
 "zope.interface" = {optional = true, version = "*"}
+validators = "^0.34.0"
 
 [tool.poetry.extras]
 s2repoze = ["paste", "repoze-who", "zope-interface"]

src/saml2/validate.py

@@ -8,6 +8,8 @@
 import time
 from urllib.parse import urlparse
 
+import validators
+
 from saml2 import time_util
 
 
@@ -420,6 +422,7 @@ def valid_instance(instance):
 
 
 def valid_domain_name(dns_name):
-    m = re.match(r"^[a-z0-9]+([-.]{ 1 }[a-z0-9]+).[a-z]{2,5}(:[0-9]{1,5})?(\/.)?$", dns_name, re.I)
-    if not m:
+    value = validators.domain(dns_name)
+    if not value:
         raise ValueError("Not a proper domain name")
+    return value

tests/test_13_validate.py

@@ -11,6 +11,7 @@
 from saml2.validate import valid_any_uri
 from saml2.validate import valid_anytype
 from saml2.validate import valid_duration
+from saml2.validate import valid_domain_name
 from saml2.validate import valid_instance
 from saml2.validate import valid_non_negative_integer
 from saml2.validate import valid_string
@@ -146,3 +147,53 @@ def test_valid_address():
         assert valid_address("[2001:8003:5555:9999:555a:5555:c77:d5c5")
     with raises(NotValid):
         assert valid_address("[[2001:8003:5555:9999:555a:5555:c77:d5c5]")
+
+
+def test_valid_domain_name():
+    assert valid_domain_name("api.my-domain.com")
+    assert valid_domain_name("auth.admin.domain.com")
+    assert valid_domain_name("auth.domain.com")
+    assert valid_domain_name("auth.domain.com")
+    assert valid_domain_name("lk.domain.com")
+    assert valid_domain_name("domain.com")
+    assert valid_domain_name("domain.lu")
+    assert valid_domain_name("auth-domain.com")
+    assert valid_domain_name("auth-admin.domain-uero.xyz")
+    assert valid_domain_name("auth.lk.d.sr.mydomain.com")
+    assert valid_domain_name("123example.com")
+
+    with raises(ValueError):
+        valid_domain_name("")
+
+    with raises(ValueError):
+        valid_domain_name("123.123.123.123")
+
+    with raises(ValueError):
+        valid_domain_name("123.123.123.123:80")
+
+    with raises(ValueError):
+        valid_domain_name("123.123.123.123:8000")
+
+    with raises(ValueError):
+        valid_domain_name("auth_domain.com")
+
+    with raises(ValueError):
+        valid_domain_name("example-.com")
+
+    with raises(ValueError):
+        valid_domain_name("[email protected]")
+
+    with raises(ValueError):
+        valid_domain_name("exaple.c")
+
+    with raises(ValueError):
+        valid_domain_name("example.com:")
+
+    with raises(ValueError):
+        valid_domain_name("example..com")
+
+    with raises(ValueError):
+        valid_domain_name("example.com123")
+
+    with raises(ValueError):
+        valid_domain_name("example.com.")