v1.1.0 dashboard updates

[egrace479]

This update brings minor version developments implemented in dev:

1. Bug fix for lat/lon out of bounds (PR Bug fix for lat lon #50, fixes Single errors in lat and lon break the map #48).
2. The size of graphs (and their titles) have been increased for improved visibility.
3. The map view now has geographic features; base layer of map come from ArcGIS (closes Add geographic features to map #49).
4. Removed case-sensitivity of columns and added long as acceptable column name for longitude (PR Recognize long and lon for longitude #51).
   • This introduced a small display bug, which was fixed in PR Fix lat/long display in hover-text #52.
5. Preview images were added to the README to reflect the changes implemented in 2 and 3 above (PR Update preview images in Readme #53).

[hlapp]

Just to clarify for what there is to review, everything in this change set was already reviewed through PRs previously, right? Or are there previously unreviewed changes that review should be focused on?

The change set is a bit big and unwieldy, but if this is just a concatenation of previously reviewed changes, then there's perhaps very little (or even nothing) to review that's new. I.e., trying to figure out what the assignment is for reviewers.

[egrace479]

Just to clarify for what there is to review, everything in this change set was already reviewed through PRs previously, right? Or are there previously unreviewed changes that review should be focused on?

The change set is a bit big and unwieldy, but if this is just a concatenation of previously reviewed changes, then there's perhaps very little (or even nothing) to review that's new. I.e., trying to figure out what the assignment is for reviewers.

Numbers 2 and 3 (commit c47c550) were not previously reviewed, but the changes from PRs noted in 4 and 5 were built on top of those changes.

[egrace479]

file_url had not been adjusted to File_url in the image path call in query or test_query in PR #51 when we adjusted all columns to be capitalized. I just fixed that.

[johnbradley]

I tested with the HCGSD_base_filepath.csv input file and the graph is very zoomed in:

---

Running on the main branch the map is properly zoomed out:

If I zoom out the map in the dev branch it looks more attractive than the main branch version.
Is there a way to get the map to automatically zoom like it previously did?

[egrace479]

I tested with the HCGSD_base_filepath.csv input file and the graph is very zoomed in:

Running on the main branch the map is properly zoomed out:

If I zoom out the map in the dev branch it looks more attractive than the main branch version. Is there a way to get the map to automatically zoom like it previously did?

It seems from this discussion that is a desired, but unimplemented feature. I do have the option to reduce the zoom to--most likely--get points on screen.

This is the zoom set to 2; it will always produce a map of this size centered on the centroid of the lat/longs provided.

Zoom set to 3 is more closely cropped, so cuts off for data with a larger spread, but works nicely for data that is more concentrated.

I think it makes more sense to err on the side of being more zoomed out (zoom set to 2), though such a large image suggests all data is caught when it may not be. What do you think? (Also, @hlapp and @thompsonmj?)

[hlapp]

I would argue the default should be to zoom out to a level that all data are shown. I think there's a good point that in terms of UX this may mean to zoom out more than strictly necessary if otherwise the view is sufficiently zoomed in to (in this case falsely) give the impression that only some of the data are shown (when really all are).

[egrace479]

I would argue the default should be to zoom out to a level that all data are shown. I think there's a good point that in terms of UX this may mean to zoom out more than strictly necessary if otherwise the view is sufficiently zoomed in to (in this case falsely) give the impression that only some of the data are shown (when really all are).

Zoom set to 1 would work unless you have data on opposite sides of the earth:

Zoom set to 0 could get duplicative, but will definitively show everything:

[egrace479]

Updated zoom to 1 with a note about the potential need to zoom to see all points.

[johnbradley]

LGTM

[hlapp]

Looks all good to me! 👍

[thompsonmj]

Tested and nothing seemed broken! I like the default view level setting.