Skip to content

feat: support env variable fo influxdb v3 #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 15, 2025
Merged

Conversation

NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented May 9, 2025

Closes #

Proposed Changes

_ Support environment variables same name as other clients
_ Support for INFLUX_GZIP_THRESHOLD will be implemented in another PR

  • INFLUX_HOST
  • INFLUX_TOKEN
  • INFLUX_AUTH_SCHEME
  • INFLUX_ORG
  • INFLUX_DATABASE
  • INFLUX_PRECISION

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this May 9, 2025
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.85%. Comparing base (7d5952f) to head (08d5e1e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   62.50%   63.85%   +1.34%     
==========================================
  Files          33       33              
  Lines        2163     2202      +39     
==========================================
+ Hits         1352     1406      +54     
+ Misses        811      796      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NguyenHoangSon96 NguyenHoangSon96 requested a review from bednar May 12, 2025 10:09
@karel-rehor karel-rehor self-requested a review May 13, 2025 08:21
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However in the description the item "CHANGELOG.md updated" is checked, but I don't see CHANGELOG.md in the list of files changed. Can you add it?

@NguyenHoangSon96
Copy link
Contributor Author

Looks good. However in the description the item "CHANGELOG.md updated" is checked, but I don't see CHANGELOG.md in the list of files changed. Can you add it?

Hi Karel, thanks for your review 😇
I plan to update the Changelog after the last PR for implement gzip_threshold (They are all the same issue but I have to separate them to small PR so It's easy to review)
By the way do you think we should implement gzip_threshold because we already have enable_gzip in python client

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK will wait for CHANGELOG.md updates in subsequent PR.

LGTM 🚣

@NguyenHoangSon96 NguyenHoangSon96 merged commit db0c51d into main May 15, 2025
15 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the feat/support-env-v1 branch May 15, 2025 01:41
@karel-rehor karel-rehor added this to the 0.13.0 milestone May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants