-
Notifications
You must be signed in to change notification settings - Fork 15
feat: support env variable fo influxdb v3 #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 62.50% 63.85% +1.34%
==========================================
Files 33 33
Lines 2163 2202 +39
==========================================
+ Hits 1352 1406 +54
+ Misses 811 796 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. However in the description the item "CHANGELOG.md updated" is checked, but I don't see CHANGELOG.md in the list of files changed. Can you add it?
Hi Karel, thanks for your review 😇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK will wait for CHANGELOG.md updates in subsequent PR.
LGTM 🚣
Closes #
Proposed Changes
_ Support environment variables same name as other clients
_ Support for INFLUX_GZIP_THRESHOLD will be implemented in another PR
Checklist