-
Notifications
You must be signed in to change notification settings - Fork 15
feat: support gzip threshold #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 63.85% 64.70% +0.85%
==========================================
Files 33 33
Lines 2202 2207 +5
==========================================
+ Hits 1406 1428 +22
+ Misses 796 779 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. I just have some minor questions or suggestions regarding branch logic and test organization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think unit tests should each handle one specific test case. But this is not a blocker.
Good to go.
Closes #
Proposed Changes
Briefly describe your proposed changes:
Checklist