Skip to content

feat: support gzip threshold #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 16, 2025
Merged

Conversation

NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented May 15, 2025

Closes #

Proposed Changes

Briefly describe your proposed changes:

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.70%. Comparing base (db0c51d) to head (8259895).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
influxdb_client_3/__init__.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   63.85%   64.70%   +0.85%     
==========================================
  Files          33       33              
  Lines        2202     2207       +5     
==========================================
+ Hits         1406     1428      +22     
+ Misses        796      779      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I just have some minor questions or suggestions regarding branch logic and test organization.

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think unit tests should each handle one specific test case. But this is not a blocker.

Good to go.

@NguyenHoangSon96 NguyenHoangSon96 merged commit cd55bcd into main May 16, 2025
15 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the feat/support-gzip-threshold branch May 16, 2025 08:48
@karel-rehor karel-rehor added this to the 0.13.0 milestone May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants