Skip to content

dpctl.get_current_queue is now cimportable #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2020
Merged

dpctl.get_current_queue is now cimportable #125

merged 1 commit into from
Oct 15, 2020

Conversation

oleksandr-pavlyk
Copy link
Contributor

This change enables changes like the following:

-    cdef c_dpctl.SyclQueue q = <c_dpctl.SyclQueue>dpctl.get_current_queue()
+    cdef c_dpctl.SyclQueue q = c_dpctl.get_current_queue()

diptorupd
diptorupd approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can be merged once CI completes.

@oleksandr-pavlyk
Copy link
Contributor Author

C is failing due to some internal CI problems. This PR can be built locally just fine. I am inclined to merge this now.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 6684c7b into master Oct 15, 2020
@oleksandr-pavlyk oleksandr-pavlyk deleted the expose-get-current-queue-on-C-side branch October 15, 2020 18:01
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
gold
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @diptorupd @PokhodenkoSA