Skip to content

Require dpcpp compiler 2024.0 and runtime >=2024.0 #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 16, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

Require dpcpp compiler 2024.0 and runtime >=2024.0

Also introduced jinja variable to keep those two in sync.

This is to be merged once DPC++=2024.0.0 compiler conda packages become available and we are ready to make the transition.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as draft October 13, 2023 16:56
@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Oct 13, 2023

Coverage Status

coverage: 85.942%. remained the same
when pulling 3a1399a on require_dpcpp_2024-port
into 9afb742 on master.

Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_4 ran successfully.
Passed: 1019
Failed: 55
Skipped: 59

Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_5 ran successfully.
Passed: 1017
Failed: 57
Skipped: 59

Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_7 ran successfully.
Passed: 1018
Failed: 56
Skipped: 59

Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_8 ran successfully.
Passed: 1018
Failed: 56
Skipped: 59

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the require_dpcpp_2024-port branch 3 times, most recently from 840b260 to b814f53 Compare November 16, 2023 01:57
Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_8 ran successfully.
Passed: 1018
Failed: 56
Skipped: 59

Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_8 ran successfully.
Passed: 1015
Failed: 59
Skipped: 59

Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_8 ran successfully.
Passed: 1016
Failed: 58
Skipped: 59

Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_10 ran successfully.
Passed: 1018
Failed: 56
Skipped: 59

Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_11 ran successfully.
Passed: 1021
Failed: 53
Skipped: 59

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review November 16, 2023 20:52
@oleksandr-pavlyk oleksandr-pavlyk merged commit f772888 into master Nov 16, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the require_dpcpp_2024-port branch November 16, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants