Skip to content

Technical debt changes #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Technical debt changes #1583

merged 3 commits into from
Mar 6, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

This PR checks in changes made during development work:

  1. Use const reference for CIndexer_vector and CIndexer_array methods for container arguments
  2. Handle possible USM-host allocation failure in "clip.hpp"
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

This should avoid unnecessary copying, even though compiler
might be optimizing them in the end anyway.
Copy link

github-actions bot commented Mar 6, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

coveralls commented Mar 6, 2024

Coverage Status

coverage: 87.449%. remained the same
when pulling b030a79 on technical-debt-changes
into 786f7fc on master.

Copy link

github-actions bot commented Mar 6, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_59 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

@ndgrigorian
Copy link
Collaborator

where.cpp was also missing handling for USM-host allocation error for strides. I've pushed it in a commit.

Copy link

github-actions bot commented Mar 6, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_60 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

@oleksandr-pavlyk oleksandr-pavlyk merged commit e69d268 into master Mar 6, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the technical-debt-changes branch March 6, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants