Skip to content

task: benchmarking with asv #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

task: benchmarking with asv #2054

merged 1 commit into from
Apr 17, 2025

Conversation

jharlow-intel
Copy link
Contributor

@jharlow-intel jharlow-intel commented Apr 15, 2025

This PR introduces ASV benchmarks to the repo.
You can find links to ASV's documentation in the added README

Once this is merged, the infra team can start finalizing the work to add these executions to the CI, allowing instant feedback on benchmarks and performance regressions during development.

The benchmarks were tested pretty exhaustively, but please let me know if I need to tweak any of the parameters or add additional benchmark cases. They work for both CPU and GPU SYCL devices as well.

@jharlow-intel jharlow-intel self-assigned this Apr 15, 2025
@jharlow-intel jharlow-intel changed the title task: :benchmarking with asv task: benchmarking with asv Apr 15, 2025
@jharlow-intel
Copy link
Contributor Author

fixing the formatting issues now

@jharlow-intel jharlow-intel force-pushed the task/benchmarking branch 2 times, most recently from f7717bd to dcd1a3d Compare April 15, 2025 17:20
Copy link

github-actions bot commented Apr 15, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_145 ran successfully.
Passed: 1110
Failed: 2
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Apr 15, 2025

Coverage Status

coverage: 86.409%. remained the same
when pulling 7b6db2e on task/benchmarking
into 041e0d1 on master.

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_145 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_146 ran successfully.
Passed: 1110
Failed: 2
Skipped: 119

1 similar comment
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_146 ran successfully.
Passed: 1110
Failed: 2
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_145 ran successfully.
Passed: 1110
Failed: 2
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_146 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_145 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_146 ran successfully.
Passed: 1110
Failed: 2
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_145 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_146 ran successfully.
Passed: 1108
Failed: 4
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_145 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_146 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_145 ran successfully.
Passed: 1108
Failed: 4
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_147 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of outcome of OS compiler build this LGTM

Thank you @jharlow-intel for working on this

@jharlow-intel jharlow-intel merged commit f57963e into master Apr 17, 2025
72 of 73 checks passed
@jharlow-intel jharlow-intel deleted the task/benchmarking branch April 17, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants