-
Notifications
You must be signed in to change notification settings - Fork 30
Feature/program interface #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
diptorupd
wants to merge
116
commits into
IntelPython:master
from
diptorupd:feature/program_interface
Closed
Feature/program interface #47
diptorupd
wants to merge
116
commits into
IntelPython:master
from
diptorupd:feature/program_interface
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the class to use.
…erfaces. - Separates out the queue manager from the sycl queue interface wrapper. - Added API to get context, device froma Sycl queue. - Added C-API wrappers for sycl device, queue, context interfaces exposing some of the API functionalities. More can be added as needed. - The dppl extension now defines extension types for sycl quque, device, context to mimic the C API. - Sycl queues are now returned to callers as a SyclQueue extension type rather than a Py_capsule.
New line at EOF.
reazulhoque
reviewed
Sep 29, 2020
conda-recipe/build.sh
Outdated
export OpenCL_LIBDIR=${DPCPP_ROOT}/lib | ||
export DPPL_OPENCL_INTERFACE_LIBDIR=dpctl | ||
export DPPL_OPENCL_INTERFACE_INCLDIR=dpctl/include | ||
export OpenCL_LIBDIR=${DPCPP_ROOT}/libw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libw -> lib? typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think lib
is correct.
Superseded by #80. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds wrappers for program and kernel. Needs more unit tests to check building program from SPIR-V and the Cython interface.