Skip to content

Bind cmake to 3.26 #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bind cmake to 3.26 #1125

wants to merge 1 commit into from

Conversation

ZzEeKkAa
Copy link
Contributor

Fixes build issues realted to the conda-forge release of cmake 3.27

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Aug 30, 2023
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd as a code owner August 30, 2023 20:01
@oleksandr-pavlyk
Copy link
Contributor

I think this has been resolve by changes in dpctl. Am I right?

@ZzEeKkAa
Copy link
Contributor Author

@oleksandr-pavlyk unfortunately no. Numba-dpex also relies on some deprecated features. #1127 is targeting to remove deprecated dependencies. This PR was just a quick fix for the CI.

@ZzEeKkAa ZzEeKkAa mentioned this pull request Sep 11, 2023
Merged
5 tasks
@diptorupd diptorupd deleted the fix/bind_cmake_to_3_26 branch September 21, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @oleksandr-pavlyk