Skip to content

Make use of "--device(s)" for XGBoost #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Alexsandruss opened this issue Dec 23, 2021 · 3 comments
Closed

Make use of "--device(s)" for XGBoost #102

Alexsandruss opened this issue Dec 23, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@Alexsandruss
Copy link
Contributor

CPU and GPU configs for XGBoost have only few differences: in data-format (pandas vs cudf) and tree-method (hist vs gpu_hist). Dispatching for them with --devices(s) argument will simplify configs.

@lulin789
Copy link

SKL_Bench_Team1 working on this issue

@lulin789
Copy link

Hi, we found that xgb_cpu_main_config.json and xgb_gpu_main_config.json not only have differences between data-format and tree-method, but also have differences in some cases as the screenshot shows:
MicrosoftTeams-image (3)
We are considering to combine CPU and GPU config files into a single file, we can use --device to handle the differences between data-format and tree-method, as for other differences, we think it can use nested dictionaries, for example, "enable-experimental-json-serialization": {"cpu": "False", "gpu": "True"}, but in this case, we need to add some code when parsing these parameters, do you think this is a good way to fix this issue? because we want to simplify configs and also keep the flexibility.

Alexsandruss added a commit to Alexsandruss/scikit-learn_bench that referenced this issue Apr 27, 2023
@Alexsandruss
Copy link
Contributor Author

Device support for XGBoost is integrated in refactoring(#133), so this issue will become solved in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants