Skip to content

Medium QoL changes #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2025
Merged

Medium QoL changes #825

merged 5 commits into from
Apr 29, 2025

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Apr 24, 2025

Changelog

- description: |
    - Deprecate `shelleyToAlonzoEraToShelleyToBabbageEra`, `alonzoEraOnwardsToMaryEraOnwards`, `babbageEraOnwardsToMaryEraOnwards`, `babbageEraOnwardsToAlonzoEraOnwards`.
    - Add `asType` for easier obtaining of `HasTypeProxy` proxies
    - Remove unneded `AsType a` functions' arguments
    - Remove some `ByronEra`-related dead code.

# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR contains few QoL changes. It should be reviewed on commit-by-commit basis.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/chore/small-fixes branch 5 times, most recently from 5ef11bb to 1e696ec Compare April 24, 2025 10:20
@carbolymer carbolymer marked this pull request as ready for review April 24, 2025 10:25
@carbolymer carbolymer force-pushed the mgalazyn/chore/small-fixes branch from 1e696ec to 38ec4bd Compare April 24, 2025 10:26
@carbolymer carbolymer changed the title Small fixes Small QoL changes Apr 24, 2025
@carbolymer carbolymer self-assigned this Apr 24, 2025
@carbolymer carbolymer force-pushed the mgalazyn/chore/small-fixes branch 3 times, most recently from f23754f to 5cc8080 Compare April 24, 2025 11:03
@@ -1159,10 +1149,11 @@ deriving instance Show (TxInsReference era)
data TxOutValue era where
TxOutValueByron
:: L.Coin
-> TxOutValue era
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jimbo4350
Copy link
Contributor

This is my main contention: #825 (comment)

@carbolymer carbolymer force-pushed the mgalazyn/chore/small-fixes branch 4 times, most recently from 022d1ce to aa567ea Compare April 29, 2025 09:47
@carbolymer carbolymer requested a review from Jimbo4350 April 29, 2025 09:49
@carbolymer carbolymer changed the title Small QoL changes Medium QoL changes Apr 29, 2025
@carbolymer carbolymer force-pushed the mgalazyn/chore/small-fixes branch from aa567ea to 5ef92ad Compare April 29, 2025 09:53
@carbolymer
Copy link
Contributor Author

@Jimbo4350 I've pushed Remove AsType usage where not necessary commit, and added small changes to the others, so you might want to review everything again.

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, happy to approve after.

@carbolymer carbolymer force-pushed the mgalazyn/chore/small-fixes branch from 5ef92ad to 3414b12 Compare April 29, 2025 13:18
@carbolymer carbolymer requested a review from Jimbo4350 April 29, 2025 13:19
@carbolymer carbolymer added this pull request to the merge queue Apr 29, 2025
Merged via the queue into master with commit 4ed8ec7 Apr 29, 2025
29 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/small-fixes branch April 29, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants