incorrect handling of metadata url in some cases

[cardanians]

poolId: pool1l92x52u37neuc2w38wrgeu3esu9qzddmzvkvyuf9vfk5gav8nxl

SELECT * FROM public.pool_offline_fetch_error
    WHERE fetch_error LIKE '%pool1l92x52u37neuc2w38wrgeu3esu9qzddmzvkvyuf9vfk5gav8nxl%'

if the metadata fails to download several times, it will stop downloading again.

This is fine in a way (but it might be worth repeating once a day anyway, wouldn't it?). however, they will not start re-fetching if the pool updates its poolcert.

Look on screen.

1. 13.7. some fetch tests with fail
2. 17.7. reregistered pool
3. then no other fetching...

Second thing is, why is this new meta url not saved in DB? He registered first url with typo "BLOOIR" (in db). Then re-registered with fix, but in db is no record about this.

latest version (v10)

[erikd]

Please do not post images in bug reports. Lack of scaling on images can make the text tiny on high res screens (like mine) and i cannot cut and paste from an image.

Instead, please cut and paste the text.

[erikd]

There seem to be at least two issues here, and they do not seem to be well distinguished.

The first problem, is that if a PoolMetadataRef update for the same PoolId and same metadata hash, but a different url will not update the table. This is due to and incomplete uniqueness constraint.

The second issue seems to be a failure to parse some URLs.

[erikd]

It seems like the error with the uniqueness constraint is confounding and confusing the other problems, so I will fix that first.

[erikd]

Lets find the pool id:

select id, view from pool_hash where view = 'pool1l92x52u37neuc2w38wrgeu3esu9qzddmzvkvyuf9vfk5gav8nxl' ;
  id   |                           view                           
-------+----------------------------------------------------------
 18067 | pool1l92x52u37neuc2w38wrgeu3esu9qzddmzvkvyuf9vfk5gav8nxl
(1 row)

and the pool_metadata_ref:

select * from pool_metadata_ref where pool_id = 18067 ;
  id   | pool_id |             url             |                  hash                 | registered_tx_id 
-------+---------+-----------------------------+---------------------------------------+------------------
 18012 |   18067 | https://blooir.com/MTD.json | \x3f192a9740e983b...7028a25fcc99400dc |          8197291
 18015 |   18067 | https://booir.com/MTD.json  | \x3f192a9740e983b...7028a25fcc99400dc |          8198428
(2 rows)

Did not pick up any pool_offline_fetch_errors for this pool_id:

select * from pool_offline_fetch_error where pool_id = 18067 ;
 id | pool_id | fetch_time | pmr_id | fetch_error | retry_count 
----+---------+------------+--------+-------------+-------------
(0 rows)

Not sure if there is another error in here somewhere, but the main one is fixed.

[cardanians]

@erikd ok awesome! can you please push new release into world? with this + rewards, thanks.

[erikd]

There is one ore thing that needs fixing, before a new release, but that should be done this week.