Epoch: Fix the epoch update logic #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This meets the requirements of: * When syncing, the rows for old epochs are only updated once after the whole epoch has been retrieved. * The point above is true even when the node is syncing (as opposed to following). Specifically, the TipBlock value provided by the node over the chain sync protocol is useless because it reports node tip, not network wide chain tip). * Only updates the current epoch when we are close to the actual chain tip. Closes: #111 Closes: #139
ksaric
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
LGTM, even though I prefer my version with tests that show how specific conditions interact with the chain. As well as extra comments that explain what each branch is doing.
This is doing the same thing as the version I submitted, but it doesn't update the current and previous epoch, just the current one.
| | epochNum > chainTipEpoch -> | ||
| -- Must just have started a new epoch, so call this which will | ||
| -- update chainTipEpoch. | ||
| | unSlotNo estTipSlot - unSlotNo tipSlot < 50 -> |
There was a problem hiding this comment.
If for some reason we have a "lag" of 50+ slots/blocks, the epoch number will not be updated until the next epoch.
There was a problem hiding this comment.
How could we have a "lag" of 50 slots? The protocol itself relies on exact times and on all block producers to agree on the same global time.
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.