Skip to content

Nix: Fix wrong git revision in version #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sgillespie
Copy link
Contributor

Description

Fixes #1961. Setting the git revision generally works, but the following packages were missed:

  • cardano-db-sync, cardano-smash-server, cardano-db-tool (via legacyPackages)
  • packages.default (nix build .\#)

This change fixes them. In addition, I've tried to remove duplicated calls to setGitRev to prevent more of these from coming up.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@sgillespie sgillespie marked this pull request as ready for review March 25, 2025 23:59
@sgillespie sgillespie requested a review from a team as a code owner March 25, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong git revison for cardano-db-sync executables
2 participants