Skip to content

Make it build with ghc-9.12 #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Make it build with ghc-9.12 #1968

wants to merge 6 commits into from

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Apr 16, 2025

Description

Make it build with ghc-9.12.

Not yet complete.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

No longer needed. GHC has been deriving this typeclass for some time
and ghc-9.12 now warns about it being redundant.
@erikd erikd requested a review from a team as a code owner April 16, 2025 08:14
@erikd erikd marked this pull request as draft April 16, 2025 08:14
erikd and others added 4 commits April 17, 2025 10:50
Needed to update the `cardano-node` dependency from `10.1.3` to
`10.3` and use all the Cardano dependencies specified by `node`.
@neilmayhew
Copy link

This needs to be rebased on #1965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants