Skip to content

Make Babbage Era de new Default after the Vasil HF #4151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
8 of 18 tasks
Tracked by #4144
, #4299
...
CarlosLopezDeLara opened this issue Jul 7, 2022 · 1 comment
Closed
8 of 18 tasks
Tracked by #4144
, #4299
...

Make Babbage Era de new Default after the Vasil HF #4151

CarlosLopezDeLara opened this issue Jul 7, 2022 · 1 comment
Assignees
@newhoggy
Labels
enhancement New feature or request in-scope This item is being worked and will be part of an upcoming release priority high issues/PRs that MUST be addressed. The release can't happen without this; priority: high Needs to be addressed as soon as possible, probably within current sprint. type: internal feature Non user-facing functionality Vasil

Comments

@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Jul 7, 2022 •
edited
Loading

What - The user facing feature being implemented

Currently Alonzo is the Default era.

After the Vasil HF, Babbage needs to default era so that you don't need the babbage-era flag any more.

Why

This is consistent with what we have done in the past to default to an era after a HF

  • cardano-cli transaction build
  • cardano-cli transaction build-raw
  • cardano-cli transaction calculate-min-required-utxo

Context: https://input-output.atlassian.net/browse/CAD-4445?focusedCommentId=94990
"The cli build commnad will need an explicit --babbage-era flag once the Babbage HF happens, up until we switch the default CLI era (to Babbage). Note that this is consistent with other commands: they explicitly need an era flag to use a new era, until the default is changed later."

Related GH issues:

Acceptance Criteria

  • GIVEN that the network is in Babbage,
    WHEN I build a transaction
    AND I do not provide any era flag
    THEN build generates a valid transaction body.
  • GIVEN that the network is in Babbage,
    WHEN I build a transaction
    AND I provide the "--babbage-era"
    THEN build generates a valid transaction body.
  • GIVEN that the network is in Babbage,
    WHEN I build-raw a transaction
    AND I do not provide any era flag
    THEN build generates a valid transaction body.
  • GIVEN that the network is in Babbage,
    WHEN I build-raw a transaction
    AND I provide the "--babbage-era"
    THEN build generates a valid transaction body.
  • GIVEN that the network is in Babbage,
    WHEN I calculate-min-required-utxo for a transaction
    AND I do not provide any era flag
    THEN calculate-min-required-utxo calculates the minimum required value for the transaction output.

Definition of done

  • Code review
  • Builds successfully on CI
  • Includes documentation and/or examples for the functionality
  • Log/record changes on Vnext (or similar depending on what we adopt)
  • Ticket number included in PR description
  • The new functionality is covered by dev/unit/property tests
  • Acceptance Criteria met
  • Test Engineering Sign-off + E2E automated tests

Sign-off

  • Dev
  • Test Engineering

Related PR

  1. PR # here --> Switch default era to Babbage #4485
@CarlosLopezDeLara CarlosLopezDeLara added enhancement New feature or request 1.35.2 priority high issues/PRs that MUST be addressed. The release can't happen without this; labels Jul 7, 2022
@CarlosLopezDeLara CarlosLopezDeLara mentioned this issue Jul 8, 2022
Open
40 tasks
@CarlosLopezDeLara CarlosLopezDeLara added in-scope This item is being worked and will be part of an upcoming release and removed 1.35.2 labels Jul 22, 2022
@CarlosLopezDeLara CarlosLopezDeLara changed the title Make Babbage Era de new Default after the HF Make Babbage Era de new Default after the Vasil HF Aug 5, 2022
@CarlosLopezDeLara CarlosLopezDeLara moved this from ✅ Done to 📋 Backlog in Node CLI/API 2022 Aug 11, 2022
@CarlosLopezDeLara CarlosLopezDeLara moved this from 📋 Backlog to 🔖 Ready in Node CLI/API 2022 Aug 11, 2022
@CarlosLopezDeLara CarlosLopezDeLara moved this from 🔖 Sprint backlog to 🏗 In progress in Node CLI/API 2022 Aug 23, 2022
@melroy89
Copy link

This make sense

@newhoggy newhoggy mentioned this issue Sep 27, 2022
Merged
@newhoggy newhoggy reopened this Sep 27, 2022
@dorin100 dorin100 mentioned this issue Sep 27, 2022
Closed
iohk-bors bot added a commit that referenced this issue Sep 28, 2022
@iohk-bors @newhoggy
Merge #4485
dbca757 
4485: Switch default era to Babbage r=Jimbo4350 a=newhoggy

Code changes required for #4151

Co-authored-by: John Ky <[email protected]>
@CarlosLopezDeLara CarlosLopezDeLara moved this from 🏗 In progress to ✅ Done in Node CLI/API 2022 Oct 11, 2022
@dorin100 dorin100 added type: internal feature Non user-facing functionality priority: high Needs to be addressed as soon as possible, probably within current sprint. labels Oct 21, 2022
@CarlosLopezDeLara CarlosLopezDeLara mentioned this issue Nov 3, 2022
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@newhoggy newhoggy

Labels
enhancement New feature or request in-scope This item is being worked and will be part of an upcoming release priority high issues/PRs that MUST be addressed. The release can't happen without this; priority: high Needs to be addressed as soon as possible, probably within current sprint. type: internal feature Non user-facing functionality Vasil
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@newhoggy @melroy89 @Jimbo4350 @dorin100 @CarlosLopezDeLara