Skip to content

Update Error messages for TxValidityUpperBoundValidationError and TxFeeValidationError #4592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Update Error messages for TxValidityUpperBoundValidationError and TxFeeValidationError #4592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cardano-cli/src/Cardano/CLI/Shelley/Run/Validate.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ data TxFeeValidationError

instance Error TxFeeValidationError where
displayError (TxFeatureImplicitFeesE era) =
"Transaction _ fee not supported in " <> Text.unpack (renderEra era)
"Implicit transaction fee not supported in " <> Text.unpack (renderEra era)
displayError (TxFeatureExplicitFeesE era) =
"Transaction _ fee not supported in " <> Text.unpack (renderEra era)
"Explicit transaction fee not supported in " <> Text.unpack (renderEra era)

validateTxFee :: CardanoEra era
-> Maybe Lovelace
Expand Down Expand Up @@ -154,7 +154,7 @@ newtype TxValidityUpperBoundValidationError

instance Error TxValidityUpperBoundValidationError where
displayError (TxValidityUpperBoundNotSupported era) =
"Transaction validity upper bound not supported in " <> Text.unpack (renderEra era)
"Transaction validity upper bound must be specified in " <> Text.unpack (renderEra era)

validateTxValidityUpperBound
:: CardanoEra era
Expand Down