Skip to content

Remove unnecessary functions #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cardano-api/src/Cardano/Api/Fees.hs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{-# LANGUAGE ConstraintKinds #-}
{-# LANGUAGE CPP #-}
{-# LANGUAGE ConstraintKinds #-}
{-# LANGUAGE DataKinds #-}
{-# LANGUAGE EmptyCase #-}
{-# LANGUAGE FlexibleContexts #-}
Expand Down
43 changes: 1 addition & 42 deletions cardano-api/src/Cardano/Api/TxBody.hs
Original file line number Diff line number Diff line change
Expand Up @@ -2724,7 +2724,7 @@ fromLedgerTxOuts era body scriptdata =
, txouts <- toList (Babbage.outputs body)
]
ShelleyBasedEraConway ->
[ fromConwayTxOut
[ fromBabbageTxOut
MultiAssetInConwayEra
ScriptDataInConwayEra
ReferenceTxInsScriptsInlineDatumsInConwayEra
Expand Down Expand Up @@ -2807,47 +2807,6 @@ fromBabbageTxOut multiAssetInEra scriptDataInEra inlineDatumsInEra txdatums txou

(BabbageTxOut addr val datum mRefScript) = txout

fromConwayTxOut
:: forall ledgerera era. Ledger.Era ledgerera
=> IsShelleyBasedEra era
=> ShelleyLedgerEra era ~ ledgerera
=> Ledger.Crypto ledgerera ~ StandardCrypto
=> Ledger.Value ledgerera ~ MaryValue StandardCrypto
=> MultiAssetSupportedInEra era
-> ScriptDataSupportedInEra era
-> ReferenceTxInsScriptsInlineDatumsSupportedInEra era
-> Map (Alonzo.DataHash StandardCrypto)
(Alonzo.Data ledgerera)
-> BabbageTxOut ledgerera
-> TxOut CtxTx era
fromConwayTxOut multiAssetInEra scriptDataInEra inlineDatumsInEra txdatums txout =
TxOut
(fromShelleyAddr shelleyBasedEra addr)
(TxOutValue multiAssetInEra (fromMaryValue val))
conwayTxOutDatum
(case mRefScript of
SNothing -> ReferenceScriptNone
SJust rScript -> fromShelleyScriptToReferenceScript shelleyBasedEra rScript
)
where
-- NOTE: This is different to 'fromConwayTxOutDatum' as it may resolve
-- 'DatumHash' values using the datums included in the transaction.
conwayTxOutDatum :: TxOutDatum CtxTx era
conwayTxOutDatum =
case datum of
Babbage.NoDatum -> TxOutDatumNone
Babbage.DatumHash dh -> resolveDatumInTx dh
Babbage.Datum d ->
TxOutDatumInline inlineDatumsInEra $
binaryDataToScriptData inlineDatumsInEra d

resolveDatumInTx :: Alonzo.DataHash StandardCrypto -> TxOutDatum CtxTx era
resolveDatumInTx dh
| Just d <- Map.lookup dh txdatums
= TxOutDatumInTx' scriptDataInEra (ScriptDataHash dh) (fromAlonzoData d)
| otherwise = TxOutDatumHash scriptDataInEra (ScriptDataHash dh)

(BabbageTxOut addr val datum mRefScript) = txout

fromLedgerTxTotalCollateral
:: ShelleyBasedEra era
Expand Down
4 changes: 2 additions & 2 deletions cardano-node/src/Cardano/Node/Tracing/Tracers/ChainDB.hs
Original file line number Diff line number Diff line change
Expand Up @@ -949,9 +949,9 @@ instance MetaTrace (ChainDB.TraceGCEvent blk) where
instance (ConvertRawHash blk, LedgerSupportsProtocol blk)
=> LogFormatting (ChainDB.TraceInitChainSelEvent blk) where
forHuman (ChainDB.InitChainSelValidation v) = forHuman v
forHuman (ChainDB.InitalChainSelected {}) =
forHuman ChainDB.InitalChainSelected{} =
"Initial chain selected"
forHuman (ChainDB.StartedInitChainSelection {}) =
forHuman ChainDB.StartedInitChainSelection {} =
"Started initial chain selection"

forMachine dtal (ChainDB.InitChainSelValidation v) = forMachine dtal v
Expand Down
21 changes: 8 additions & 13 deletions cardano-node/src/Cardano/Tracing/Startup.hs
Original file line number Diff line number Diff line change
@@ -1,28 +1,26 @@
{-# LANGUAGE FlexibleContexts #-}
{-# LANGUAGE MultiParamTypeClasses #-}
{-# LANGUAGE UndecidableInstances #-}
{-# LANGUAGE UndecidableInstances #-}

{-# OPTIONS_GHC -Wno-orphans #-}

module Cardano.Tracing.Startup where

import Prelude
import Data.Text (Text)
import Prelude

import Cardano.Logging (LogFormatting (..))
import Cardano.Node.Startup
import Cardano.Node.Tracing.Compat
import Cardano.Node.Tracing.Tracers.Startup
import Cardano.Tracing.OrphanInstances.Network ()

import Cardano.BM.Tracing (HasPrivacyAnnotation (..),
HasSeverityAnnotation (..), Severity (..), ToObject (..),
Transformable (..))
import Cardano.BM.Data.Tracer (HasTextFormatter (..),
trStructuredText)
import Cardano.BM.Data.Tracer (HasTextFormatter (..), trStructuredText)
import Cardano.BM.Tracing (HasPrivacyAnnotation (..), HasSeverityAnnotation (..),
Severity (..), ToObject (..), Transformable (..))

import Ouroboros.Consensus.Node.NetworkProtocolVersion
(BlockNodeToClientVersion, BlockNodeToNodeVersion)
import Ouroboros.Consensus.Node.NetworkProtocolVersion (BlockNodeToClientVersion,
BlockNodeToNodeVersion)


instance HasSeverityAnnotation (StartupTrace blk) where
Expand All @@ -43,10 +41,7 @@ instance ( Show (BlockNodeToNodeVersion blk)
=> Transformable Text IO (StartupTrace blk) where
trTransformer = trStructuredText

instance ( Show (BlockNodeToNodeVersion blk)
, Show (BlockNodeToClientVersion blk)
)
=> HasTextFormatter (StartupTrace blk) where
instance HasTextFormatter (StartupTrace blk) where
formatText a _ = ppStartupInfoTrace a

instance ( Show (BlockNodeToNodeVersion blk)
Expand Down