-
Notifications
You must be signed in to change notification settings - Fork 89
Account for new ledger refactor. #3933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d01b031
to
ea5bf15
Compare
e0f0981
to
2daff78
Compare
nfrisby
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One action requested (updating the Haddock). Otherwise, Approved. Thanks!
2daff78
to
8ff77c3
Compare
Recent PR to ledger: IntersectMBO/cardano-ledger#2901 introduced a lot of breaking changes. This commit accounts for those changes
8ff77c3
to
774f3e4
Compare
bors merge |
newhoggy
pushed a commit
that referenced
this pull request
Aug 19, 2022
3933: Account for new ledger refactor. r=lehins a=lehins Recent PR to ledger: IntersectMBO/cardano-ledger#2901 introduced a lot of breaking changes. This PR accounts for those changes. # Description <!-- CI flakiness -- delete this before opening a PR Sadly, some CI checks are currently flaky. Right now, this includes: - GH Actions Windows job runs out of memory, e.g. in https://github.com/input-output-hk/ouroboros-network/runs/7231748864?check_suite_focus=true - The Hydra check for test-storage on Windows (mingwW64) fails with inscrutable malloc-related error messages: https://hydra.iohk.io/build/16260881/nixlog/1 - The tests in WallClock.delay* can fail under load (quite rarely): https://hydra.iohk.io/build/16723452/nixlog/76 If you encounter one of these, try restarting the job to see if the failure vanishes. If it does not or when in doubt, consider posting in the #network or #consensus channels on Slack. --> _description of the pull request, if it fixes a particular issue it should link the PR to a particular issue, see [ref](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword=)_ Co-authored-by: Alexey Kuleshevich <[email protected]>
iohk-bors bot
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Dec 7, 2022
4608: Update ouroboros-network and cardano-ledger dependencies r=angerman a=Soupstraw This PR updates ouroboros-network and cardano-ledger dependencies. This bumps `cardano-ledger` to `0.1.1.1`, which is IntersectMBO/cardano-ledger#3080. This in turn is the `release/1.1.x` branch + heapword split compatibility introduced in `cardano-base`, which is in CHaP. It also bumps ouroboros-network to [a38f898a](https://github.com/input-output-hk/ouroboros-network/commits/a38f898a3740925ccaa0617fa870ca7054a485a6), which is 45 commits ahead of the old [c764553](https://github.com/input-output-hk/ouroboros-network/commits/c764553561bed8978d2c6753d1608dc65449617a) pin. This is one commit ahead of what IntersectMBO/ouroboros-network#3933 (on ouroboros-network/master), that made network compatible with IntersectMBO/cardano-ledger#2901 Co-authored-by: Joosep Jääger <[email protected]> Co-authored-by: Samuel Leathers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent PR to ledger: IntersectMBO/cardano-ledger#2901 introduced
a lot of breaking changes. This PR accounts for those changes.
Description
description of the pull request, if it fixes a particular issue it should link
the PR to a particular issue, see
ref
Checklist
interface-CHANGELOG.md
interface-CHANGELOG.md