Skip to content

Account for new ledger refactor. #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Aug 2, 2022

Recent PR to ledger: IntersectMBO/cardano-ledger#2901 introduced
a lot of breaking changes. This PR accounts for those changes.

Description

description of the pull request, if it fixes a particular issue it should link
the PR to a particular issue, see
ref

Checklist

  • Branch
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • New tests are added if needed and existing tests are updated
    • If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@JaredCorduan
Copy link
Contributor

The fact that this PR, an integration of a massive refactor in the ledger, is only ~100 lines, is such a clear indication of what a spectacular job @edsko and @mrBliss did to abstract the ledger inside of consensus.

@newhoggy newhoggy mentioned this pull request Aug 5, 2022
9 tasks
@lehins lehins force-pushed the lehins/account-for-ledger-refactoring branch 3 times, most recently from d01b031 to ea5bf15 Compare August 9, 2022 10:03
@lehins lehins force-pushed the lehins/account-for-ledger-refactoring branch 2 times, most recently from e0f0981 to 2daff78 Compare August 16, 2022 12:07
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One action requested (updating the Haddock). Otherwise, Approved. Thanks!

@lehins lehins force-pushed the lehins/account-for-ledger-refactoring branch from 2daff78 to 8ff77c3 Compare August 17, 2022 17:12
Recent PR to ledger: IntersectMBO/cardano-ledger#2901 introduced
a lot of breaking changes. This commit accounts for those changes
@lehins lehins force-pushed the lehins/account-for-ledger-refactoring branch from 8ff77c3 to 774f3e4 Compare August 17, 2022 18:36
@lehins
Copy link
Contributor Author

lehins commented Aug 17, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 17, 2022

@iohk-bors iohk-bors bot merged commit ca4fa9b into master Aug 17, 2022
@iohk-bors iohk-bors bot deleted the lehins/account-for-ledger-refactoring branch August 17, 2022 21:37
newhoggy pushed a commit that referenced this pull request Aug 19, 2022
3933: Account for new ledger refactor. r=lehins a=lehins

Recent PR to ledger: IntersectMBO/cardano-ledger#2901 introduced
a lot of breaking changes. This PR accounts for those changes.

# Description

<!-- CI flakiness -- delete this before opening a PR

Sadly, some CI checks are currently flaky. Right now, this includes:

 - GH Actions Windows job runs out of memory, e.g. in https://github.com/input-output-hk/ouroboros-network/runs/7231748864?check_suite_focus=true

 - The Hydra check for test-storage on Windows (mingwW64) fails with inscrutable malloc-related error messages: https://hydra.iohk.io/build/16260881/nixlog/1

 - The tests in WallClock.delay* can fail under load (quite rarely): https://hydra.iohk.io/build/16723452/nixlog/76

If you encounter one of these, try restarting the job to see if the failure vanishes. If it does not or when in doubt, consider posting in the #network or #consensus channels on Slack.
-->

_description of the pull request, if it fixes a particular issue it should link
the PR to a particular issue, see
[ref](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword=)_

Co-authored-by: Alexey Kuleshevich <[email protected]>
iohk-bors bot added a commit to IntersectMBO/cardano-node that referenced this pull request Dec 7, 2022
4608: Update ouroboros-network and cardano-ledger dependencies r=angerman a=Soupstraw

This PR updates ouroboros-network and cardano-ledger dependencies. 

This bumps `cardano-ledger` to `0.1.1.1`, which is IntersectMBO/cardano-ledger#3080. This in turn is the `release/1.1.x` branch + heapword split compatibility introduced in `cardano-base`, which is in CHaP.

It also bumps ouroboros-network to [a38f898a](https://github.com/input-output-hk/ouroboros-network/commits/a38f898a3740925ccaa0617fa870ca7054a485a6), which is 45 commits ahead of the old [c764553](https://github.com/input-output-hk/ouroboros-network/commits/c764553561bed8978d2c6753d1608dc65449617a) pin.
This is one commit ahead of what IntersectMBO/ouroboros-network#3933 (on ouroboros-network/master), that made network compatible with IntersectMBO/cardano-ledger#2901

Co-authored-by: Joosep Jääger <[email protected]>
Co-authored-by: Samuel Leathers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants