Skip to content

Tracing async-exceptions #5116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 30, 2025
Merged

Tracing async-exceptions #5116

merged 4 commits into from
May 30, 2025

Conversation

coot
Copy link
Contributor

@coot coot commented Apr 25, 2025 •
edited
Loading

Description

  • outbound-governor: don't trace async-exceptions
  • server: don't trace async-exceptions
  • connection-manager: don't trace async-exceptions
  • connection-manager: counters

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@coot coot requested a review from a team as a code owner April 25, 2025 11:38
@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network Apr 25, 2025
@coot coot added connection-manager Issues / PRs related to connection-manager outbound-governor Issues / PRs related to outbound-governor labels Apr 25, 2025
@coot coot force-pushed the coot/async-exceptions-handling branch 2 times, most recently from 3383d4a to e2bad2b Compare April 25, 2025 12:17
@coot coot self-assigned this Apr 25, 2025
crocodile-dentist
crocodile-dentist approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coot coot added this pull request to the merge queue Apr 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 25, 2025
@coot coot added this pull request to the merge queue May 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 14, 2025
@coot coot added this pull request to the merge queue May 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2025
@coot coot added this pull request to the merge queue May 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2025
@coot coot force-pushed the coot/async-exceptions-handling branch from e2bad2b to 24414c7 Compare May 28, 2025 10:47
@coot coot enabled auto-merge May 28, 2025 10:47
@coot coot force-pushed the coot/async-exceptions-handling branch from 24414c7 to 68d994a Compare May 29, 2025 10:12
coot added 4 commits May 30, 2025 10:03
@coot
outbound-governor: don't trace async-exceptions
223229e 
The outbound-governor can be killed by an `AsyncException`, we shouldn't
trace such cases as `TraceOutboundGovernorCriticalFailure`.

The same for PeerStateActions's establishPeerConnection method.
@coot
server: don't trace async-exceptions
d0ed192 
We should ignore all async-exceptions, not just `AsyncCancelled`.
@coot
connection-manager: don't trace async-exceptions
1297599
@coot
connection-manager: counters
1b54ab5 
* Added `terminating` connections;
* Fixed an issue when we trace counters, but they haven't changed.
@coot coot force-pushed the coot/async-exceptions-handling branch from 68d994a to 1b54ab5 Compare May 30, 2025 08:08
@coot coot added this pull request to the merge queue May 30, 2025
Merged via the queue into main with commit 045109f May 30, 2025
12 checks passed
@coot coot deleted the coot/async-exceptions-handling branch May 30, 2025 09:20
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ouroboros Network May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crocodile-dentist crocodile-dentist crocodile-dentist approved these changes

Assignees

@coot coot

Labels
connection-manager Issues / PRs related to connection-manager outbound-governor Issues / PRs related to outbound-governor
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coot @crocodile-dentist