Skip to content

Simplify code for changing the checkstate #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joachimmarder opened this issue Jun 11, 2018 · 2 comments
Closed

Simplify code for changing the checkstate #805

joachimmarder opened this issue Jun 11, 2018 · 2 comments
Assignees
@joachimmarder
Labels
Enhancement In Development
Milestone
V7.1

Comments

@joachimmarder
Copy link
Contributor

joachimmarder commented Jun 11, 2018 •
edited
Loading

The code when a node is checked is overly complex, because Virtual Treeview supports pending check state changes both for keyboard and for mouse. This causes problems like #790 and #285 or makes feature request like #745 unnecessary complex to implements. Neither Windows Explorer nor the Windows ListView common control has or supports these pending check states.

I don't see a significant benefit in them and vote for removing them and making the behavior similar to Windows Explorer and the ListView common control.

Proposed changes:

  • Remove tskeyCheckPending and tsMouseCheckPending
  • Remove FCheckNode and FPendingCheckState
  • Apply check state change on key / mouse button down
@joachimmarder joachimmarder self-assigned this Jun 11, 2018
@joachimmarder joachimmarder added the Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. label Jun 11, 2018
@joachimmarder joachimmarder added this to the V7.1 milestone Jun 11, 2018
joachimmarder pushed a commit that referenced this issue Jun 11, 2018
Centralized check for vsDisabled when checking in DoChecking(). Prepa…
864bc15 
…ration for #805 and #745.
@pyscripter
Copy link
Contributor

+1

1 similar comment
@sanjayssk
Copy link
Contributor

+1

@GoranDespalatovic GoranDespalatovic mentioned this issue Aug 8, 2018
Closed
@joachimmarder joachimmarder added In Development and removed Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. labels Dec 17, 2018
joachimmarder added a commit that referenced this issue Dec 17, 2018
@joachimmarder
Fixed issue #805: implify code for changing the checkstate
bef8f9f
Sharlikran pushed a commit to ElminsterAU/Virtual-TreeView that referenced this issue Jan 17, 2019
@joachimmarder @Sharlikran
Fixed issue JAM-Software#805: implify code for changing the checkstate
6b46bf1
@joachimmarder joachimmarder mentioned this issue Mar 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joachimmarder joachimmarder

Labels
Enhancement In Development
Projects
None yet
Milestone
V7.1
Development

No branches or pull requests
3 participants
@pyscripter @joachimmarder @sanjayssk