Upgrade action to Node v16 and actions/core to v1.10

.github/workflows/ci-cd.yml

@@ -21,7 +21,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     timeout-minutes: 10
     strategy:
-      fail-fast: true
+      fail-fast: false
       matrix:
         os:
           - ubuntu-latest

action.yml

@@ -61,5 +61,5 @@ outputs:
     description: The version number that was previously published to NPM
 
 runs:
-  using: node12
+  using: node16
   main: dist/index.js

package.json

@@ -40,16 +40,14 @@
     "test": "mocha && npm run lint",
     "coverage": "nyc -x test -x dist/sourcemap-register.js node_modules/mocha/bin/mocha",
     "upgrade": "npm-check -u && npm audit fix",
-    "bump": "bump --tag --push --all && git tag -afm v1 v1 && git push --tags --force",
-    "release": "npm run clean && npm run build && npm test && npm run bump",
     "_eslint": "eslint \"**/*.@(js|ts)\"",
     "_prettier": "prettier \"**/*.@(js|ts|json|md|yml)\""
   },
   "engines": {
     "node": ">=16"
   },
   "devDependencies": {
-    "@actions/core": "^1.2.6",
+    "@actions/core": "^1.10.0",
     "@jsdevtools/chai-exec": "^2.1.1",
     "@jsdevtools/eslint-config": "^1.1.4",
     "@jsdevtools/version-bump-prompt": "^6.1.0",

src/action/index.ts

@@ -1,4 +1,9 @@
-import { debug, getInput, setFailed, setOutput } from "@actions/core";
+import {
+  debug,
+  getInput,
+  setFailed,
+  setOutput as setOutputActionsCore,
+} from "@actions/core";
 import { npmPublish } from "../npm-publish";
 import { Access, Options } from "../options";
 
@@ -62,6 +67,17 @@ async function main(): Promise<void> {
   }
 }
 
+/**
+ * Set output with logging to stdout for test support
+ */
+function setOutput(...args: Parameters<typeof setOutputActionsCore>) {
+  if (process.env.NODE_ENV === "test") {
+    console.log(`TEST::set-output name=${args[0]}::${args[1]}`);
+    return;
+  }
+  return setOutputActionsCore(...args);
+}
+
 /**
  * Prints errors to the GitHub Actions console
  */

src/npm-publish.ts

@@ -35,6 +35,7 @@ export async function npmPublish(opts: Options = {}): Promise<Results> {
 
   let results: Results = {
     package: manifest.name,
+    registry: options.registry,
     // The version should be marked as lower if we disallow decrementing the version
     type:
       (options.greaterVersionOnly && cmp === -1 && "lower") || diff || "none",

src/results.ts

@@ -17,6 +17,11 @@ export interface Results {
    */
   package: string;
 
+  /**
+   * The registry where the NPM package was published
+   */
+  registry: URL;
+
   /**
    * The version that was published
    */

test/fixtures/mocha-hooks.js

@@ -3,6 +3,8 @@
 const { promises: fs } = require("fs");
 const paths = require("../utils/paths");
 
+process.env.NODE_ENV = "test";
+
 /**
  * Re-create the .tmp directories before each test
  */

test/specs/action/failure.spec.js

@@ -9,6 +9,8 @@ const { EOL } = require("os");
 
 describe("GitHub Action - failure tests", () => {
   it("should fail if the NPM token isn't set", () => {
+    files.create([{ path: "workspace/not-package.json", contents: {} }]);
+
     let cli = exec.action({
       env: {
         INPUT_TOKEN: "",

test/specs/action/success.spec.js

@@ -49,12 +49,12 @@ describe("GitHub Action - success tests", () => {
     expect(cli).stdout.to.include(
       "Successfully published my-lib v2.0.0 to https://registry.npmjs.org/"
     );
-    expect(cli).stdout.to.include("::set-output name=type::major");
-    expect(cli).stdout.to.include("::set-output name=version::2.0.0");
-    expect(cli).stdout.to.include("::set-output name=old-version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::latest");
-    expect(cli).stdout.to.include("::set-output name=access::public");
-    expect(cli).stdout.to.include("::set-output name=dry-run::false");
+    expect(cli).stdout.to.include("TEST::set-output name=type::major");
+    expect(cli).stdout.to.include("TEST::set-output name=version::2.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::latest");
+    expect(cli).stdout.to.include("TEST::set-output name=access::public");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::false");
     expect(cli).to.have.exitCode(0);
 
     files.assert.contents(
@@ -106,12 +106,12 @@ describe("GitHub Action - success tests", () => {
     expect(cli).stdout.to.include(
       "Successfully published my-lib v0.1.0 to https://registry.npmjs.org/"
     );
-    expect(cli).stdout.to.include("::set-output name=type::major");
-    expect(cli).stdout.to.include("::set-output name=version::0.1.0");
-    expect(cli).stdout.to.include("::set-output name=old-version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::latest");
-    expect(cli).stdout.to.include("::set-output name=access::public");
-    expect(cli).stdout.to.include("::set-output name=dry-run::false");
+    expect(cli).stdout.to.include("TEST::set-output name=type::major");
+    expect(cli).stdout.to.include("TEST::set-output name=version::0.1.0");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::latest");
+    expect(cli).stdout.to.include("TEST::set-output name=access::public");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::false");
     expect(cli).to.have.exitCode(0);
 
     files.assert.contents(
@@ -163,12 +163,12 @@ describe("GitHub Action - success tests", () => {
     expect(cli).stdout.to.include(
       "my-lib v0.1.0 is lower than the version published to https://registry.npmjs.org/"
     );
-    expect(cli).stdout.to.include("::set-output name=type::lower");
-    expect(cli).stdout.to.include("::set-output name=version::0.1.0");
-    expect(cli).stdout.to.include("::set-output name=old-version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::latest");
-    expect(cli).stdout.to.include("::set-output name=access::public");
-    expect(cli).stdout.to.include("::set-output name=dry-run::false");
+    expect(cli).stdout.to.include("TEST::set-output name=type::lower");
+    expect(cli).stdout.to.include("TEST::set-output name=version::0.1.0");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::latest");
+    expect(cli).stdout.to.include("TEST::set-output name=access::public");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::false");
     expect(cli).to.have.exitCode(0);
 
     files.assert.contents(
@@ -221,12 +221,12 @@ describe("GitHub Action - success tests", () => {
     expect(cli).stdout.to.include(
       "Successfully published my-lib v1.0.0 to https://registry.npmjs.org/"
     );
-    expect(cli).stdout.to.include("::set-output name=type::major");
-    expect(cli).stdout.to.include("::set-output name=version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=old-version::0.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::latest");
-    expect(cli).stdout.to.include("::set-output name=access::public");
-    expect(cli).stdout.to.include("::set-output name=dry-run::false");
+    expect(cli).stdout.to.include("TEST::set-output name=type::major");
+    expect(cli).stdout.to.include("TEST::set-output name=version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::0.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::latest");
+    expect(cli).stdout.to.include("TEST::set-output name=access::public");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::false");
     expect(cli).to.have.exitCode(0);
 
     files.assert.contents(
@@ -278,12 +278,12 @@ describe("GitHub Action - success tests", () => {
     expect(cli).stdout.to.include(
       "Successfully published my-lib v1.0.0 to https://registry.npmjs.org/"
     );
-    expect(cli).stdout.to.include("::set-output name=type::major");
-    expect(cli).stdout.to.include("::set-output name=version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=old-version::0.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::my-tag");
-    expect(cli).stdout.to.include("::set-output name=access::public");
-    expect(cli).stdout.to.include("::set-output name=dry-run::false");
+    expect(cli).stdout.to.include("TEST::set-output name=type::major");
+    expect(cli).stdout.to.include("TEST::set-output name=version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::0.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::my-tag");
+    expect(cli).stdout.to.include("TEST::set-output name=access::public");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::false");
     expect(cli).to.have.exitCode(0);
 
     files.assert.contents(
@@ -323,12 +323,12 @@ describe("GitHub Action - success tests", () => {
     expect(cli).stdout.to.include(
       "📦 my-lib v1.0.0 is already published to https://registry.npmjs.org/"
     );
-    expect(cli).stdout.to.include("::set-output name=type::none");
-    expect(cli).stdout.to.include("::set-output name=version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=old-version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::latest");
-    expect(cli).stdout.to.include("::set-output name=access::public");
-    expect(cli).stdout.to.include("::set-output name=dry-run::false");
+    expect(cli).stdout.to.include("TEST::set-output name=type::none");
+    expect(cli).stdout.to.include("TEST::set-output name=version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::latest");
+    expect(cli).stdout.to.include("TEST::set-output name=access::public");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::false");
     expect(cli).to.have.exitCode(0);
 
     files.assert.contents(
@@ -385,12 +385,12 @@ describe("GitHub Action - success tests", () => {
     expect(cli).stdout.to.include(
       "📦 Successfully published my-lib v1.1.0 to https://registry.npmjs.org/"
     );
-    expect(cli).stdout.to.include("::set-output name=type::minor");
-    expect(cli).stdout.to.include("::set-output name=version::1.1.0");
-    expect(cli).stdout.to.include("::set-output name=old-version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::latest");
-    expect(cli).stdout.to.include("::set-output name=access::public");
-    expect(cli).stdout.to.include("::set-output name=dry-run::false");
+    expect(cli).stdout.to.include("TEST::set-output name=type::minor");
+    expect(cli).stdout.to.include("TEST::set-output name=version::1.1.0");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::latest");
+    expect(cli).stdout.to.include("TEST::set-output name=access::public");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::false");
     expect(cli).to.have.exitCode(0);
 
     files.assert.contents(
@@ -459,12 +459,12 @@ describe("GitHub Action - success tests", () => {
     expect(cli).stdout.to.include(
       "📦 Successfully published my-lib v1.0.1 to https://registry.npmjs.org/"
     );
-    expect(cli).stdout.to.include("::set-output name=type::patch");
-    expect(cli).stdout.to.include("::set-output name=version::1.0.1");
-    expect(cli).stdout.to.include("::set-output name=old-version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::latest");
-    expect(cli).stdout.to.include("::set-output name=access::public");
-    expect(cli).stdout.to.include("::set-output name=dry-run::false");
+    expect(cli).stdout.to.include("TEST::set-output name=type::patch");
+    expect(cli).stdout.to.include("TEST::set-output name=version::1.0.1");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::latest");
+    expect(cli).stdout.to.include("TEST::set-output name=access::public");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::false");
     expect(cli).to.have.exitCode(0);
 
     files.assert.contents(
@@ -525,12 +525,12 @@ describe("GitHub Action - success tests", () => {
     expect(cli).stdout.to.include(
       "📦 Successfully published my-lib v1.0.0-beta to https://registry.npmjs.org/"
     );
-    expect(cli).stdout.to.include("::set-output name=type::prerelease");
-    expect(cli).stdout.to.include("::set-output name=version::1.0.0-beta");
-    expect(cli).stdout.to.include("::set-output name=old-version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::latest");
-    expect(cli).stdout.to.include("::set-output name=access::public");
-    expect(cli).stdout.to.include("::set-output name=dry-run::false");
+    expect(cli).stdout.to.include("TEST::set-output name=type::prerelease");
+    expect(cli).stdout.to.include("TEST::set-output name=version::1.0.0-beta");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::latest");
+    expect(cli).stdout.to.include("TEST::set-output name=access::public");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::false");
     expect(cli).to.have.exitCode(0);
 
     files.assert.contents(
@@ -582,12 +582,12 @@ describe("GitHub Action - success tests", () => {
     expect(cli).stdout.to.include(
       "Successfully published @my-scope/my-lib v2.0.0 to https://registry.npmjs.org/"
     );
-    expect(cli).stdout.to.include("::set-output name=type::major");
-    expect(cli).stdout.to.include("::set-output name=version::2.0.0");
-    expect(cli).stdout.to.include("::set-output name=old-version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::latest");
-    expect(cli).stdout.to.include("::set-output name=access::restricted");
-    expect(cli).stdout.to.include("::set-output name=dry-run::false");
+    expect(cli).stdout.to.include("TEST::set-output name=type::major");
+    expect(cli).stdout.to.include("TEST::set-output name=version::2.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::latest");
+    expect(cli).stdout.to.include("TEST::set-output name=access::restricted");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::false");
     expect(cli).to.have.exitCode(0);
 
     files.assert.contents(
@@ -640,12 +640,12 @@ describe("GitHub Action - success tests", () => {
     expect(cli).stdout.to.include(
       "Successfully published my-lib v2.0.0 to https://registry.npmjs.org/"
     );
-    expect(cli).stdout.to.include("::set-output name=type::major");
-    expect(cli).stdout.to.include("::set-output name=version::2.0.0");
-    expect(cli).stdout.to.include("::set-output name=old-version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::next");
-    expect(cli).stdout.to.include("::set-output name=access::public");
-    expect(cli).stdout.to.include("::set-output name=dry-run::false");
+    expect(cli).stdout.to.include("TEST::set-output name=type::major");
+    expect(cli).stdout.to.include("TEST::set-output name=version::2.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::next");
+    expect(cli).stdout.to.include("TEST::set-output name=access::public");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::false");
     expect(cli).to.have.exitCode(0);
 
     files.assert.contents(
@@ -698,12 +698,12 @@ describe("GitHub Action - success tests", () => {
     expect(cli).stdout.to.include(
       "Successfully published @my-scope/my-lib v2.0.0 to https://registry.npmjs.org/"
     );
-    expect(cli).stdout.to.include("::set-output name=type::major");
-    expect(cli).stdout.to.include("::set-output name=version::2.0.0");
-    expect(cli).stdout.to.include("::set-output name=old-version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::latest");
-    expect(cli).stdout.to.include("::set-output name=access::public");
-    expect(cli).stdout.to.include("::set-output name=dry-run::false");
+    expect(cli).stdout.to.include("TEST::set-output name=type::major");
+    expect(cli).stdout.to.include("TEST::set-output name=version::2.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::latest");
+    expect(cli).stdout.to.include("TEST::set-output name=access::public");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::false");
     expect(cli).to.have.exitCode(0);
 
     files.assert.contents(
@@ -752,12 +752,12 @@ describe("GitHub Action - success tests", () => {
     });
 
     expect(cli).to.have.stderr("");
-    expect(cli).stdout.to.include("::set-output name=type::minor");
-    expect(cli).stdout.to.include("::set-output name=version::1.1.0");
-    expect(cli).stdout.to.include("::set-output name=old-version::1.0.0");
-    expect(cli).stdout.to.include("::set-output name=tag::latest");
-    expect(cli).stdout.to.include("::set-output name=access::public");
-    expect(cli).stdout.to.include("::set-output name=dry-run::true");
+    expect(cli).stdout.to.include("TEST::set-output name=type::minor");
+    expect(cli).stdout.to.include("TEST::set-output name=version::1.1.0");
+    expect(cli).stdout.to.include("TEST::set-output name=old-version::1.0.0");
+    expect(cli).stdout.to.include("TEST::set-output name=tag::latest");
+    expect(cli).stdout.to.include("TEST::set-output name=access::public");
+    expect(cli).stdout.to.include("TEST::set-output name=dry-run::true");
     expect(cli).stdout.to.include("my-lib 1.1.0");
     expect(cli).stdout.to.include(
       "📦 my-lib v1.1.0 was NOT actually published to https://registry.npmjs.org/ (dry run)"

test/specs/lib/success.spec.js

@@ -50,6 +50,7 @@ describe("NPM package - success tests", () => {
     expect(results).to.deep.equal({
       type: "major",
       package: "my-lib",
+      registry: new URL("https://registry.npmjs.org/"),
       version: "2.0.0",
       oldVersion: "1.0.0",
       tag: "latest",
@@ -97,6 +98,7 @@ describe("NPM package - success tests", () => {
     expect(results).to.deep.equal({
       type: "major",
       package: "my-lib",
+      registry: new URL("https://registry.npmjs.org/"),
       version: "1.0.0",
       oldVersion: "0.0.0",
       tag: "latest",
@@ -142,6 +144,7 @@ describe("NPM package - success tests", () => {
     expect(results).to.deep.equal({
       type: "major",
       package: "my-lib",
+      registry: new URL("https://registry.npmjs.org/"),
       version: "1.0.0",
       oldVersion: "0.0.0",
       tag: "my-tag",
@@ -177,6 +180,7 @@ describe("NPM package - success tests", () => {
     expect(results).to.deep.equal({
       type: "none",
       package: "my-lib",
+      registry: new URL("https://registry.npmjs.org/"),
       version: "1.0.0",
       oldVersion: "1.0.0",
       tag: "latest",
@@ -226,6 +230,7 @@ describe("NPM package - success tests", () => {
     expect(results).to.deep.equal({
       type: "prerelease",
       package: "my-lib",
+      registry: new URL("https://registry.npmjs.org/"),
       version: "1.0.0-beta.1",
       oldVersion: "1.0.0",
       tag: "latest",
@@ -272,6 +277,7 @@ describe("NPM package - success tests", () => {
     expect(results).to.deep.equal({
       type: "minor",
       package: "my-lib",
+      registry: new URL("https://registry.npmjs.org/"),
       version: "1.1.0",
       oldVersion: "1.0.0",
       tag: "latest",
@@ -334,6 +340,7 @@ describe("NPM package - success tests", () => {
     expect(results).to.deep.equal({
       type: "patch",
       package: "my-lib",
+      registry: new URL("https://registry.npmjs.org/"),
       version: "1.0.1",
       oldVersion: "1.0.0",
       tag: "latest",
@@ -390,6 +397,7 @@ describe("NPM package - success tests", () => {
     expect(results).to.deep.equal({
       type: "prerelease",
       package: "my-lib",
+      registry: new URL("https://registry.npmjs.org/"),
       version: "1.0.0-beta",
       oldVersion: "1.0.0",
       tag: "latest",
@@ -435,6 +443,7 @@ describe("NPM package - success tests", () => {
     expect(results).to.deep.equal({
       type: "major",
       package: "@my-scope/my-lib",
+      registry: new URL("https://registry.npmjs.org/"),
       version: "2.0.0",
       oldVersion: "1.0.0",
       tag: "latest",
@@ -480,6 +489,7 @@ describe("NPM package - success tests", () => {
     expect(results).to.deep.equal({
       type: "major",
       package: "my-lib",
+      registry: new URL("https://registry.npmjs.org/"),
       version: "2.0.0",
       oldVersion: "1.0.0",
       tag: "next",
@@ -525,6 +535,7 @@ describe("NPM package - success tests", () => {
     expect(results).to.deep.equal({
       type: "major",
       package: "@my-scope/my-lib",
+      registry: new URL("https://registry.npmjs.org/"),
       version: "2.0.0",
       oldVersion: "1.0.0",
       tag: "latest",
@@ -574,6 +585,7 @@ describe("NPM package - success tests", () => {
     expect(results).to.deep.equal({
       type: "minor",
       package: "my-lib",
+      registry: new URL("https://registry.npmjs.org/"),
       version: "1.1.0",
       oldVersion: "1.0.0",
       tag: "latest",