Skip to content

Commit afc71ed

Browse files
almada39subhramit
andauthored
Fix: Refresh groupTree after removing group (fixes #11487) (#12815)
* Fix #11487: Refresh groupTree after removing group * Refactor: Refresh groupTree after any group command --------- Co-authored-by: Subhramit Basu <[email protected]>
1 parent 5d6d979 commit afc71ed

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
8787
- We fixed an issue where JabRef displayed dropdown triangle in wrong place in "Search for unlinked local files" dialog [#12713](https://github.com/JabRef/jabref/issues/12713)
8888
- We fixed an issue where JabRef would not open if an invalid external journal abbreviation path was encountered. [#12776](https://github.com/JabRef/jabref/issues/12776)
8989
- We fixed a bug where LaTeX commands were not removed from filenames generated using the `[bibtexkey] - [fulltitle]` pattern. [#12188](https://github.com/JabRef/jabref/issues/12188)
90+
- We fixed an issue where JabRef interface would not properly refresh after a group removal. [#11487](https://github.com/JabRef/jabref/issues/11487)
9091

9192
### Removed
9293

src/main/java/org/jabref/gui/groups/GroupTreeView.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -719,16 +719,14 @@ public void execute() {
719719
viewModel.removeGroupKeepSubgroups(group);
720720
case GROUP_REMOVE_WITH_SUBGROUPS ->
721721
viewModel.removeGroupAndSubgroups(group);
722-
case GROUP_EDIT, GROUP_SUBGROUP_RENAME -> {
723-
viewModel.editGroup(group);
724-
groupTree.refresh();
725-
}
722+
case GROUP_EDIT, GROUP_SUBGROUP_RENAME ->
723+
viewModel.editGroup(group);
726724
case GROUP_GENERATE_EMBEDDINGS ->
727725
viewModel.generateEmbeddings(group);
728726
case GROUP_GENERATE_SUMMARIES ->
729727
viewModel.generateSummaries(group);
730728
case GROUP_CHAT ->
731-
viewModel.chatWithGroup(group);
729+
viewModel.chatWithGroup(group);
732730
case GROUP_SUBGROUP_ADD ->
733731
viewModel.addNewSubgroup(group, GroupDialogHeader.SUBGROUP);
734732
case GROUP_SUBGROUP_REMOVE ->
@@ -746,6 +744,7 @@ public void execute() {
746744
case GROUP_ENTRIES_REMOVE ->
747745
viewModel.removeSelectedEntries(group);
748746
}
747+
groupTree.refresh();
749748
}
750749
}
751750

0 commit comments

Comments
 (0)