Skip to content

Error in group interface: Tooltip shown for groups without descrition can be a desription from some other group #11487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
OlafKleinBerlin opened this issue Jul 12, 2024 · 16 comments · Fixed by #12815

Comments

@OlafKleinBerlin
Copy link

OlafKleinBerlin commented Jul 12, 2024

JabRef version

5.15 (latest release, snap-Version)

Operating system

GNU / Linux

Details on version and operating system

Operating System: Kubuntu 22.04 KDE Plasma Version: 5.24.7 KDE Frameworks Version: 5.92.0 Qt Version: 5.15.3 Kernel Version: 6.5.0-41-generic (64-bit) Graphics Platform: X11 Processors: 8 × 11th Gen Intel® Core™ i7-1185G7 @ 3.00GHz Memory: 15,3 GiB of RAM Graphics Processor: Mesa Intel® Xe Graphics,

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Load a bibtex file with some groups with description and with some groups without description, e.g. the attached bibtex-file
  2. Open the Group interface
  3. Move the mouse pointer above the group names and wait for the tooltip to show up. Then, at least some times it holds for groups without description e.g. the Test group 2 without description in the attached file that the description of some other group is shown. This can also be a description from some other bibtex file that has been shown before. Here a screen shot generated with the mouse pointer at group 2:
    Screenshot_Groups_tooltip

P.S.: I lied when I clicked the I have tested the latest development version and the problem persists box above, since I need my jabref installation for my work and to not dare to risk it by playing around with your latest development version since that may create temporary files somewhere or may do other thinks that may cause problems afterwards if I start JabRef 5.15 again. But, after I spotted this error already in 2023, I decided now to ignore your demotivation for reporting bugs.

`

Appendix

...

Bibtex-File
@Comment{jabref-meta: databaseType:bibtex;}

@Comment{jabref-meta: grouping:
0 AllEntriesGroup:;
1 StaticGroup:Test group 1 without description\;2\;1\;\;\;\;;
2 StaticGroup:Subroup 1 of test group 1 without destiption\;0\;1\;\;\;\;;
2 StaticGroup:Subgroup 2 of text group 1 with descrtiption\;0\;1\;\;\;Description of Subgroup 2 of text group 1\;;
1 StaticGroup:Test group 2 without description\;2\;1\;\;\;\;;
1 StaticGroup:Test group 3 with description\;2\;1\;\;\;Description of group 3\;;
1 StaticGroup:Test group 4 with descriptoin\;2\;1\;\;\;Description of group 4\;;
}
@yeonissa
Copy link

yeonissa commented Oct 8, 2024

Hi @OlafKleinBerlin, I would like to work on this issue. Could you please assign it to me?
Thanks

@OlafKleinBerlin
Copy link
Author

Dear @yeonissa,

thanks for your interest in this issue. I am sorry, but it seems that I am not able to assign anyone to this issue, even if I had opened it. I am a normal gitlab user without the corresponding permissions for the JabRef repository.

Dear @Siedlerchr, dear @koppor,
I would be grateful if you could assign @yeonissa to this issue or if you could point out how to proceed for doing this.

Greetings
Olaf

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@yeonissa
Copy link

yeonissa commented Oct 9, 2024

Hi @OlafKleinBerlin, I’ve decided to work on another issue(#11785) with my classmates. Could you please help unassign me from this one? Thank you for your understanding, and I appreciate your support!

@Siedlerchr Siedlerchr removed the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 9, 2024
@calixtus calixtus removed the [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs label Feb 24, 2025
@almada39
Copy link
Contributor

almada39 commented Mar 7, 2025

Hi, i would like to work on this issue, can i be assigned please? @Siedlerchr @koppor

Copy link
Contributor

github-actions bot commented Mar 7, 2025

👋 Hey @almada39, it looks like you're interested in working on this issue! 🎉

If you'd like to take on this issue, please use the command /assign-me to assign yourself.

@koppor
Copy link
Member

koppor commented Mar 7, 2025

/assign @almada39

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

👋 Hey @almada39, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 21 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@github-actions github-actions bot removed the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 22, 2025
Copy link
Contributor

📋 Assignment Update

Hi @almada39, due to inactivity, you have been unassigned from this issue.

Next steps

If you still want to work on this:

  • Ask a maintainer to assign you again
  • If you're making progress, a maintainer can add the pin label to prevent future automatic unassignment

@almada39
Copy link
Contributor

Hi! I am still working on this issue, I'm getting somewhere. Could I get reassigned, please? @koppor
Thank you!

@koppor koppor added 📍 Assigned Assigned by assign-issue-action (or manually assigned) 📌 Pinned labels Mar 23, 2025
almada39 added a commit to almada39/jabref that referenced this issue Mar 24, 2025
github-merge-queue bot pushed a commit that referenced this issue Mar 25, 2025
* Fix #11487: Refresh groupTree after removing group

* Refactor: Refresh groupTree after any group command

---------

Co-authored-by: Subhramit Basu <[email protected]>
@github-project-automation github-project-automation bot moved this from Normal priority to Done in Prioritization Mar 25, 2025
@OlafKleinBerlin
Copy link
Author

Dear @Siedlerchr, dear all,

Since the problem I described when creating this issue showed up without any removing of a group, I doubt that
a fix for dealing with "Refresh groupTree after removing group" will have solved this problem.
Hence, I would like to ask for reopening this issue.

Many thanks in advance.
Greetings
Olaf Klein

@Siedlerchr Siedlerchr reopened this Mar 26, 2025
@Siedlerchr
Copy link
Member

@OlafKleinBerlin Would you mind testing the latest dev version and check this https://builds.jabref.org/main/ ?

@koppor
Copy link
Member

koppor commented Mar 26, 2025

The changelog entry of @almada39 is a bit mis-leading. The code at https://github.com/JabRef/jabref/pull/12815/files does a refresh after all group actions.

@OlafKleinBerlin
Copy link
Author

OlafKleinBerlin commented Mar 26, 2025

Hello,

   @Siedlerchr thanks for reopening the issue. 

I have just tested the lastest dev version, and the result is that for my test example the problem disappeared but is still there for other files.

I have tested two last dev versions:

  • the portable Linux version JabRef-6.0-portable_linux.tar.gz from https://builds.jabref.org/main/ with the description
    "JavaFX 24+29
    JabRef 6.0-alpha.356--2025-03-25--afc71ed
    Linux 6.8.0-56-generic amd64
    Java 23.0.1
    JavaFX 24+29"
  • the edge snap version with the description
    "JabRef 6.0-alpha.356--2025-03-25--afc71ed
    Linux 6.8.0-56-generic amd64
    Java 23.0.1
    JavaFX 24+29"

And the result is the same for all both files: Considering the example file discussed in the opening of the issue there seems seems to no tooltip shown for groups without a description. But, loading in addition the bibtex file I inserted below and moving the mouse pointer over the groups whose names starts with "No desc." since there is no description for these groups, it holds at least for some of them that some description text is shown. This text is copied from some other group description. This can also be a group description from the other file.
And to my great surprise it may happen now that after returning to the first file: At least some times it happens that while moving the mouse pointer over a group without a description now some tooltip with some description text is shown.

To my surprise, I am also no longer able to reproduce the problem in the issue description with the example file with the stable snap version i.e. jabref 5.15.60000 3232 latest/stable koppor, but can observe also the problem with the other file. Maybe this is due to some update of my laptop since creating the issue in the summer of 2024 or due to playing around
with snap.

**Other bibtex file example, inserted as .txt file since bibtex files are rejected **and the insertion as code removed the backslashes in the output.

sos-hytop-groups-only.txt

@koppor koppor moved this from Done to Normal priority in Prioritization Mar 31, 2025
GuilhermeRibeiroPereira pushed a commit to GuilhermeRibeiroPereira/jabref that referenced this issue Apr 1, 2025
…Ref#12815)

* Fix JabRef#11487: Refresh groupTree after removing group

* Refactor: Refresh groupTree after any group command

---------

Co-authored-by: Subhramit Basu <[email protected]>
Copy link
Contributor

⏰ Assignment Reminder

Hi @almada39, this is a friendly reminder about your assignment to this issue.

Warning

This issue will be automatically unassigned in 11 days if there's no activity.

How to keep your assignment


If you are working on it, you can prevent automatic unassignment by:

  • Submitting a draft PR with your progress
  • Asking for the 📌 Pinned label if you need more time

We appreciate your contribution and are here to help if needed!

krishnagjsForGit pushed a commit to krishnagjsForGit/jabref that referenced this issue May 2, 2025
…Ref#12815)

* Fix JabRef#11487: Refresh groupTree after removing group

* Refactor: Refresh groupTree after any group command

---------

Co-authored-by: Subhramit Basu <[email protected]>
krishnagjsForGit pushed a commit to krishnagjsForGit/jabref that referenced this issue May 2, 2025
…Ref#12815)

* Fix JabRef#11487: Refresh groupTree after removing group

* Refactor: Refresh groupTree after any group command

---------

Co-authored-by: Subhramit Basu <[email protected]>
@github-actions github-actions bot removed 📍 Assigned Assigned by assign-issue-action (or manually assigned) 🔔 reminder-sent labels May 5, 2025
Copy link
Contributor

github-actions bot commented May 5, 2025

📋 Assignment Update

Hi @almada39, due to inactivity, you have been unassigned from this issue.

Next steps


If you still want to work on this:

  • Submit a pull request showing your current state. You will be automatically assigned again.
  • Ask a maintainer to assign you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Normal priority
Development

Successfully merging a pull request may close this issue.

6 participants