-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add support for LTWA (List of Title Word Abbreviations) #10541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To ease organizational workflows I have linked the pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
|
I don't see anything except a whitespace change? Did you push your changes? |
@@ -230,7 +230,7 @@ public void addAbbreviation(Abbreviation abbreviationObject) { | |||
public void addAbbreviation() { | |||
addAbbreviation(new Abbreviation( | |||
Localization.lang("Name"), | |||
Localization.lang("Abbreviation"), | |||
Localization.lang("abbreviation"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the change here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly! I think I accidentally made this change, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still on early stage this PR. No MV file handling etc.
@@ -40,6 +40,7 @@ public static JournalAbbreviationRepository loadRepository(JournalAbbreviationPr | |||
LOGGER.warn("There is no journal-list.mv. We use a default journal list"); | |||
repository = new JournalAbbreviationRepository(); | |||
} else { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No unnecesary newline changes please
Since there was no activity for a long time, I'll close this PR. Feel free to open a new PR in case you resume work on this. |
Resolves https://github.com/koppor/jabref/issues/215
The current problem is that the matcher is design to match the whole title.
The matcher has to be rewritten to match single words.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)