Skip to content

Add support for LTWA (List of Title Word Abbreviations) #10541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

wenshilanR
Copy link

@wenshilanR wenshilanR commented Oct 22, 2023

Resolves https://github.com/koppor/jabref/issues/215

The current problem is that the matcher is design to match the whole title.

2023-10-22 20 27 47

The matcher has to be rewritten to match single words.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@ThiloteE
Copy link
Member

To ease organizational workflows I have linked the pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

@Siedlerchr
Copy link
Member

I don't see anything except a whitespace change? Did you push your changes?

@Siedlerchr Siedlerchr changed the title Add support for LTWA Add support for LTWA (List of Title Word Abbreviations) Oct 28, 2023
@@ -230,7 +230,7 @@ public void addAbbreviation(Abbreviation abbreviationObject) {
public void addAbbreviation() {
addAbbreviation(new Abbreviation(
Localization.lang("Name"),
Localization.lang("Abbreviation"),
Localization.lang("abbreviation"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the change here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly! I think I accidentally made this change, sorry.

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still on early stage this PR. No MV file handling etc.

@@ -40,6 +40,7 @@ public static JournalAbbreviationRepository loadRepository(JournalAbbreviationPr
LOGGER.warn("There is no journal-list.mv. We use a default journal list");
repository = new JournalAbbreviationRepository();
} else {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No unnecesary newline changes please

@koppor
Copy link
Member

koppor commented Jan 2, 2024

Since there was no activity for a long time, I'll close this PR. Feel free to open a new PR in case you resume work on this.

@koppor koppor closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants