-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
(Test) commit submodules #12755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Test) commit submodules #12755
Conversation
I think, I mixed up again |
Still not working. Need to check. |
@koppor it seems to me like we are triggering the error when NO submodule changes are detected (! in front) |
The |
Woohoo done |
I guess this test PR is now obsolete |
Let me try out once - as it was not working last time |
Signed-off-by: subhramit <[email protected]>
71274d9
to
e903781
Compare
Job was skipped, olly probably disabled the test |
@trag-bot didn't find any issues in the code! ✅✨ |
Hey, we noticed that you force-pushed your changes. Force pushing is a bad practice when working together on a project (mainly because it is not supported well by GitHub itself). Commits are lost and comments on commits lose their context, thus making it harder to review changes. At the end, all commits will be squashed anyway before being merged into the In future, please avoid that. For now, you can continue working. |
To test #12752
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)