Skip to content

(Test) commit submodules #12755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

subhramit
Copy link
Member

To test #12752

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@subhramit
Copy link
Member Author

@subhramit subhramit requested a review from koppor March 16, 2025 21:27
@koppor
Copy link
Member

koppor commented Mar 16, 2025

@koppor false positive? JabRef/jabref/actions/runs/13887489384/job/38854160250?pr=12755

I think, I mixed up again pull_request ( contributor branch with all changes, but not with full token rights) and pull_request_target (main branch with full token rights). Check is now done at pull_request - fa74258

@koppor
Copy link
Member

koppor commented Mar 16, 2025

Still not working. Need to check.

@subhramit subhramit marked this pull request as draft March 16, 2025 21:46
@subhramit
Copy link
Member Author

@koppor it seems to me like we are triggering the error when NO submodule changes are detected (! in front)

@koppor
Copy link
Member

koppor commented Mar 16, 2025

@koppor it seems to me like we are triggering the error when NO submodule changes are detected (! in front)

The -vz in grep reverses the grep change

@subhramit
Copy link
Member Author

Woohoo done

@koppor koppor closed this Mar 16, 2025
@subhramit subhramit deleted the test-submodules branch March 16, 2025 22:21
@subhramit subhramit restored the test-submodules branch April 18, 2025 10:15
@subhramit subhramit reopened this Apr 18, 2025
@koppor koppor moved this to High priority in Prioritization Apr 18, 2025
@JabRef JabRef deleted a comment from github-actions bot Apr 18, 2025
@Siedlerchr
Copy link
Member

I guess this test PR is now obsolete

@Siedlerchr Siedlerchr closed this May 24, 2025
@github-project-automation github-project-automation bot moved this from High priority to Done in Prioritization May 24, 2025
@subhramit
Copy link
Member Author

I guess this test PR is now obsolete

Let me try out once - as it was not working last time

@subhramit subhramit reopened this May 24, 2025
Signed-off-by: subhramit <[email protected]>
@subhramit
Copy link
Member Author

Job was skipped, olly probably disabled the test
Closing for now till needed

@subhramit subhramit closed this May 24, 2025
Copy link

trag-bot bot commented May 24, 2025

@trag-bot didn't find any issues in the code! ✅✨

@jabref-machine
Copy link
Collaborator

Hey, we noticed that you force-pushed your changes. Force pushing is a bad practice when working together on a project (mainly because it is not supported well by GitHub itself). Commits are lost and comments on commits lose their context, thus making it harder to review changes. At the end, all commits will be squashed anyway before being merged into the main branch.

In future, please avoid that. For now, you can continue working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants