Fix: Allow pasting PDF URLs into main table to create entries #12911

Kaan0029 · 2025-04-08T03:04:59Z

Previously, pasting a URL that ended in .pdf into the main table showed an error: “Could not find suitable import format.” This change improves usability by allowing users to paste PDF links directly (e.g. on Windows 10 via clicking into the main table and then pressing CTRL + V), and automatically adds a corresponding BibEntry with metadata and file attachment.

Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/201

This change:

Adds support for detecting and handling .pdf URLs in ImportHandler#handleStringData
Downloads the PDF into the library’s file directory
Extracts metadata using PdfMergeMetadataImporter
Creates a new BibEntry and attaches the downloaded file

Manual Testing

This feature was manually tested:

Pasted a .pdf URL into the main table
Confirmed the file was downloaded into the database's file directory
Confirmed a new BibEntry was created with metadata and file linked
Confirmed fallback behavior: when no metadata is present, an empty entry with the file is created

No test case added because this feature relies on clipboard input and file download behavior, which are difficult to mock in unit tests.

Screenshots

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
[/] Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (if change is visible to the user)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

subhramit

Comments on first look

subhramit · 2025-04-08T03:43:54Z

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

@@ -399,6 +402,16 @@ public List<BibEntry> handleStringData(String data) throws FetcherException {
        if ((data == null) || data.isEmpty()) {
            return Collections.emptyList();
        }
+        LOGGER.debug("Checking if URL is a PDF: {}", data);
+
+        if (org.jabref.logic.util.URLUtil.isURL(data) && data.toLowerCase().endsWith(".pdf")) {


Why use fully qualified package link instead of import?

Thanks, I changed it.
Unhealthy reflex sometimes😅

subhramit · 2025-04-08T03:46:03Z

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

@@ -399,6 +402,16 @@ public List<BibEntry> handleStringData(String data) throws FetcherException {
        if ((data == null) || data.isEmpty()) {
            return Collections.emptyList();
        }
+        LOGGER.debug("Checking if URL is a PDF: {}", data);


For me it would be OK. Maybe with "trace" level?

I agree with the comments. Trace level seems suitable since it provides low level detail. In hindsight, debug feels too noisy (especially given how often handleStringData gets called)

I changed it to trace level

subhramit · 2025-04-08T03:48:04Z

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

+            urlDownload.toFile(targetFile);
+        } catch (FetcherException fe) {
+            LOGGER.error("Error downloading PDF from URL", fe);
+            throw new IOException("Error downloading PDF", fe);


Why does this have to be wrapped into an IOException?

Yeah it doesn't have to be–thanks for the catch! I changed it

subhramit · 2025-04-08T03:49:00Z

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

+                entries.add(emptyEntry);
+            }
+            return entries;
+        } catch (Exception ex) {


Do not catch generic exceptions.

I changed it to IO Exception.

subhramit · 2025-04-08T03:50:42Z

src/main/resources/csl-styles

Revert the submodule changes as per https://devdocs.jabref.org/code-howtos/faq.html#submodules

I reverted them–thank you for the reminder!

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

…handling

Kaan0029 · 2025-04-10T01:30:31Z

Could someone please create an issue for this PR? The issue was listed in a non-public repo.
Thanks in advance!

Edit: Sorry for the force push (ran into some sync issues with my local setup after a rebase)

Siedlerchr · 2025-04-12T16:29:50Z

No need for rebasing. We squash all commits after merging the PR

Siedlerchr · 2025-04-12T16:31:24Z

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

+        }
+    }
+
+    private String deriveFileNameFromUrl(String url) {


Use FileUtil.getValidFileName

Siedlerchr · 2025-04-12T16:33:48Z

Please link the melting pot issue, even if it's not visible for everyone. In the changelog you can create an entry and reference the PR numner

Kaan0029 · 2025-04-12T18:56:15Z

Please link the melting pot issue, even if it's not visible for everyone. In the changelog you can create an entry and reference the PR numner

Unfortunately, I didn't receive a melting pot link for this issue. I just received a problem description and proceeded with solving it. Do you want me to share that "description" with you?

ThiloteE · 2025-04-13T10:35:30Z

If there is no issue, then it's fine. The description in the pull-request is good enough as is.

Siedlerchr

Works

obsolete

InAnYan · 2025-04-13T17:31:47Z

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

+        }
+        LOGGER.trace("Checking if URL is a PDF: {}", data);
+
+        if (URLUtil.isURL(data) && data.toLowerCase().endsWith(".pdf")) {


I wonder, can you extract somehow last element of the URL, so that it resembles a path.

And then use method FileUtil#isPDFFile (https://github.com/JabRef/jabref/blob/main/src/main/java/org/jabref/logic/util/io/FileUtil.java#L494)

If extraction of last elements would take too much code -- then it's okay to leave as is

I implemented your suggestions.
This way added a few more lines, but I prefer it that way: more maintainable and cleaner.

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

jabref-machine · 2025-04-14T03:57:51Z

Your pull request needs to link an issue.

To ease organizational workflows, please link this pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue:

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

close

closes

closed

fix

fixes

fixed

resolve

resolves

resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

Examples

✅ Fixes #xyz links pull-request to issue. Merging the PR will close the issue.
✅ Fixes https://github.com/JabRef/jabref/issues/xyz links pull-request to issue. Merging the PR will close the issue.
✅ Fixes https://github.com/Koppor/jabref/issues/xyz links pull-request to issue. Merging the PR will close the issue.
❌ Fixes [#xyz](https://github.com/JabRef/jabref/issues/xyz) links pull-request to issue. Merging the PR will NOT close the issue.

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

…#12911) * Improve handling of PDF file import behavior * Add support for handling PDF URLs when pasted * Revert submodule changes * Replace Collections.emptyList() with List.of() and improve exception handling * Change log level from debug to trace for PDF URL * Registered fix in changelog * Used getValidFileName for helper method deriveFileNameFromUrl * Refactor PDF URL detection using FileUtil.isPDFFile * Move getFileNameFromURL helper method to URLUtil class

subhramit previously requested changes Apr 8, 2025

View reviewed changes

koppor reviewed Apr 8, 2025

View reviewed changes

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java Outdated Show resolved Hide resolved

trag-bot bot reviewed Apr 8, 2025

View reviewed changes

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java Show resolved Hide resolved

trag-bot bot reviewed Apr 8, 2025

View reviewed changes

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java Show resolved Hide resolved

Kaan0029 added 5 commits April 9, 2025 21:12

Improve handling of PDF file import behavior

7762d9f

Add support for handling PDF URLs when pasted

fcb9e36

Revert submodule changes

fd53d23

Replace Collections.emptyList() with List.of() and improve exception …

fa40fd3

…handling

Change log level from debug to trace for PDF URL

ef322c6

Kaan0029 force-pushed the fix-pdf-url-paste branch from 6c9ee9f to ef322c6 Compare April 10, 2025 01:25

Siedlerchr reviewed Apr 12, 2025

View reviewed changes

Siedlerchr added the status: changes-required Pull requests that are not yet complete label Apr 12, 2025

Kaan0029 added 3 commits April 13, 2025 12:30

Registered fix in changelog

d1a2c5a

Used getValidFileName for helper method deriveFileNameFromUrl

9387443

Merge branch 'main' into fix-pdf-url-paste

96a4f4a

Siedlerchr previously approved these changes Apr 13, 2025

View reviewed changes

Siedlerchr enabled auto-merge April 13, 2025 17:27

Siedlerchr added this pull request to the merge queue Apr 13, 2025

InAnYan reviewed Apr 13, 2025

View reviewed changes

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java Outdated Show resolved Hide resolved

Siedlerchr removed this pull request from the merge queue due to a manual request Apr 13, 2025

Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: changes-required Pull requests that are not yet complete labels Apr 13, 2025

Refactor PDF URL detection using FileUtil.isPDFFile

dec141d

Kaan0029 added 2 commits April 13, 2025 19:25

Merge remote-tracking branch 'upstream/main' into fix-pdf-url-paste

efa619c

Move getFileNameFromURL helper method to URLUtil class

049c3e1

Kaan0029 dismissed Siedlerchr’s stale review via 049c3e1 April 14, 2025 03:56

trag-bot bot reviewed Apr 14, 2025

View reviewed changes

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java Show resolved Hide resolved

trag-bot bot reviewed Apr 14, 2025

View reviewed changes

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java Show resolved Hide resolved

trag-bot bot reviewed Apr 14, 2025

View reviewed changes

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java Show resolved Hide resolved

Siedlerchr approved these changes Apr 14, 2025

View reviewed changes

Siedlerchr added this pull request to the merge queue Apr 14, 2025

Merged via the queue into JabRef:main with commit efb055f Apr 14, 2025
1 check passed

Uh oh!

Fix: Allow pasting PDF URLs into main table to create entries #12911

Fix: Allow pasting PDF URLs into main table to create entries #12911

Uh oh!

Conversation

Kaan0029 commented Apr 8, 2025 • edited by ThiloteE Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Manual Testing

Screenshots

Mandatory checks

Uh oh!

subhramit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kaan0029 commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siedlerchr commented Apr 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr commented Apr 12, 2025

Uh oh!

Kaan0029 commented Apr 12, 2025

Uh oh!

ThiloteE commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siedlerchr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jabref-machine commented Apr 14, 2025

Linking a pull request to an issue using a keyword

Examples

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kaan0029 commented Apr 8, 2025 •

edited by ThiloteE

Loading

Kaan0029 commented Apr 10, 2025 •

edited

Loading

ThiloteE commented Apr 13, 2025 •

edited

Loading