Skip to content
This repository was archived by the owner on Jan 14, 2019. It is now read-only.

feat: change logic of distinguishing patterns from statements #118

Merged
merged 4 commits into from
Jan 12, 2019

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jan 12, 2019

This PR changes logic how patterns are distinguished from statements

@codecov
Copy link

codecov bot commented Jan 12, 2019

Codecov Report

Merging #118 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   93.05%   93.22%   +0.16%     
==========================================
  Files           8        8              
  Lines        1412     1357      -55     
  Branches      346      319      -27     
==========================================
- Hits         1314     1265      -49     
+ Misses         54       51       -3     
+ Partials       44       41       -3
Impacted Files Coverage Δ
src/node-utils.ts 95.29% <ø> (-0.29%) ⬇️
src/convert.ts 93.86% <100%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 868e760...3d6ad10. Read the comment docs.

@armano2 armano2 changed the title WIP: feat: change logic of distinguishing patterns from statements feat: change logic of distinguishing patterns from statements Jan 12, 2019
@armano2
Copy link
Contributor Author

armano2 commented Jan 12, 2019

ok, its ready

should i remove no longer used helper functions from utils?

  • findAncestorOfKind
  • findChildOfKind
  • findFirstMatchingAncestor

@JamesHenry
Copy link
Owner

Merged in the extra test cases you made, sorry for the conflicts

@armano2
Copy link
Contributor Author

armano2 commented Jan 12, 2019

nah thats was a point, to make this PR reflect only actual changes.

what i should do with those utils functions?

@JamesHenry
Copy link
Owner

Sure you can go ahead and remove them, we can always dig them out of the git history if we need them again!

@JamesHenry JamesHenry merged commit f11e368 into JamesHenry:master Jan 12, 2019
@JamesHenry
Copy link
Owner

🎉 This PR is included in version 17.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants