This repository was archived by the owner on Jan 14, 2019. It is now read-only.
fix(*): brute force initial conversion to TS #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHenry
force-pushed
the
ts
branch
2 times, most recently
from
231f6d8 to
85b0e77
Compare
JamesHenry
changed the title
|
I have updated the commit to be a |
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
FYI there’s an |
|
Nice work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deliberately approached this large PR as a first step - force the tsc to compile the codebase successfully without making runtime changes to it.
E.g. in a code path which is currently exposed to possible unaccounted for null values, and would therefore be flagged by
strictNullChecks, the solution in this PR is to use type assertions/casting. In follow up PRs the underlying issues will be fixed.I have painstakingly recreated the ESTree spec (type info from that not yet in use though to align with the above intentions).
Yuck:
Yay:
...but up and running with TypeScript source 🎉