Skip to content
This repository was archived by the owner on Jan 14, 2019. It is now read-only.

fix(ast): fix wrong node type on literal expressions #4

Merged
merged 2 commits into from
Oct 8, 2018
Merged

fix(ast): fix wrong node type on literal expressions #4

merged 2 commits into from
Oct 8, 2018

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Sep 24, 2018

@JamesHenry
Copy link
Owner

JamesHenry commented Sep 27, 2018

Apologies, @g-plane, I suddenly realised I hadn't been checking the commit format. I have now set up linting for it, it should follow the conventional changelog style:

type(scope?): subject
body?
footer?

This is because I release automatically using semantic-release.

Please could you update your commit message?

@g-plane
Copy link
Contributor Author

g-plane commented Sep 27, 2018

Maybe I just need to update the PR title? Then, you can squash and merge it.

@g-plane g-plane changed the title Breaking: fix wrong node type on literal expressions fix(ast): fix wrong node type on literal expressions Sep 27, 2018
@JamesHenry
Copy link
Owner

I really appreciate the quick response (caught me a little off guard how prompt you were! :D ), I have since added formatting with prettier to the repo.

Both the formatting and the commit messages are checked as part of the build now. I would feel more comfortable getting everything up to date and having a passing build before merging please.

Also please remember to add the BREAKING back in the commit body, in this commit style it is not represented in the subject, it is in the commit body.

You can use the cz npm script to use an interactive prompt to build the commit message too just FYI

@JamesHenry
Copy link
Owner

Sorry again that I made extra work for you on this

@g-plane
Copy link
Contributor Author

g-plane commented Sep 27, 2018

No problem and I will do it later.

BREAKING:
This will change the AST structure.
@g-plane
Copy link
Contributor Author

g-plane commented Sep 28, 2018

@JamesHenry Updated.

@JamesHenry JamesHenry merged commit c3ea1d2 into JamesHenry:master Oct 8, 2018
@JamesHenry
Copy link
Owner

Thanks again @g-plane!

@JamesHenry
Copy link
Owner

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@g-plane g-plane deleted the fix-literal-node-type branch October 9, 2018 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants