This repository was archived by the owner on Jan 14, 2019. It is now read-only.
refactor: mark AsteriskAsteriskEquals as assignment operator #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
reviewed
Dec 13, 2018
armano2
force-pushed
the
asterisk_asterisk_equals_token
branch
from
383d44d to
aeeec11
Compare
|
Can you add a test? |
armano2
force-pushed
the
asterisk_asterisk_equals_token
branch
from
aeeec11 to
247be57
Compare
armano2
changed the title
j-f1
previously approved these changes
Dec 14, 2018
JamesHenry
previously approved these changes
Dec 14, 2018
armano2
force-pushed
the
asterisk_asterisk_equals_token
branch
from
c47d66d to
664f590
Compare
j-f1
approved these changes
Dec 14, 2018
|
@armano2 You should be able to just push new commits since since this repo uses squash-merging so all the commits will be combined when the PR is merged. |
|
@j-f1 yes and no, commit message check is failing allays when i try to do 2nd commit i added missing: - function getTextForTokenKind(kind: number): string | undefined {
+ function getTextForTokenKind(kind: ts.SyntaxKind): string | undefined {and changed also: - const TOKEN_TO_TEXT: { readonly [P in keyof typeof SyntaxKind]?: string } = {
+ const TOKEN_TO_TEXT: { readonly [P in ts.SyntaxKind]?: string } = { |
|
@armano2 It looks like you just have to follow the guidelines from this package. |
|
🎉 This PR is included in version 7.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds AsteriskAsteriskEquals
**=to assigmentOperators operator