Added whitespace handling to regexp. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this loader is mostly intended to be a workaround for these modules, and I don't see any problems with allowing whitespace before the shebang. However in this PR you only changed the regexp in the If you wanted to do that in this PR I'll merge it in. |
|
Great. Funny how I missed it on line 4. I added it there too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds whitespace handling to the matching regexp, as I've seen files in some node modules (e.g. JSONStream) contain extra whitespace before the shebang.
Allowing extra whitespace in the beginning is not really inline with the definition of shebangs, but making this loader a bit more generic allows using those files, instead of trying to fix every node module out there.