Skip to content

Commit a4257e5

Browse files
authoredDec 20, 2024··
fix: remove unnecessary default values from .all-contributorsrc (#1784)
## PR Checklist - [x] Addresses an existing open issue: fixes #1783 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Straightforward removal of config settings. Note the lack of actual changes to the `README.md` file. 🔪
1 parent c13be58 commit a4257e5

File tree

4 files changed

+3
-29
lines changed

4 files changed

+3
-29
lines changed
 

‎.all-contributorsrc

+1-11
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
{
22
"badgeTemplate": "\t<a href=\"#contributors\" target=\"_blank\"><img alt=\"👪 All Contributors: <%= contributors.length %>\" src=\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\" /></a>",
3-
"commit": false,
4-
"commitConvention": "angular",
5-
"commitType": "docs",
63
"contributors": [
74
{
85
"avatar_url": "https://avatars.githubusercontent.com/u/3335181?v=4",
@@ -483,14 +480,7 @@
483480
]
484481
}
485482
],
486-
"contributorsPerLine": 7,
487483
"contributorsSortAlphabetically": true,
488-
"files": [
489-
"README.md"
490-
],
491-
"imageSize": 100,
492484
"projectName": "create-typescript-app",
493-
"projectOwner": "JoshuaKGoldberg",
494-
"repoHost": "https://github.com",
495-
"repoType": "github"
485+
"projectOwner": "JoshuaKGoldberg"
496486
}

‎src/next/blocks/blockAllContributors.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe("blockAllContributors", () => {
2121
},
2222
],
2323
"files": {
24-
".all-contributorsrc": "{"badgeTemplate":"\\t<a href=\\"#contributors\\" target=\\"_blank\\"><img alt=\\"👪 All Contributors: <%= contributors.length %>\\" src=\\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\\" /></a>","commit":false,"commitConvention":"angular","commitType":"docs","contributors":[],"contributorsPerLine":7,"contributorsSortAlphabetically":true,"files":["README.md"],"imageSize":100,"projectName":"test-repository","projectOwner":"test-owner","repoHost":"https://github.com","repoType":"github"}",
24+
".all-contributorsrc": "{"badgeTemplate":"\\t<a href=\\"#contributors\\" target=\\"_blank\\"><img alt=\\"👪 All Contributors: <%= contributors.length %>\\" src=\\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\\" /></a>","contributors":[],"contributorsSortAlphabetically":true,"projectName":"test-repository","projectOwner":"test-owner"}",
2525
".github": {
2626
"workflows": {
2727
"contributors.yml": "jobs:
@@ -88,7 +88,7 @@ describe("blockAllContributors", () => {
8888
},
8989
],
9090
"files": {
91-
".all-contributorsrc": "{"badgeTemplate":"\\t<a href=\\"#contributors\\" target=\\"_blank\\"><img alt=\\"👪 All Contributors: <%= contributors.length %>\\" src=\\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\\" /></a>","commit":false,"commitConvention":"angular","commitType":"docs","contributors":[{"avatar_url":"https://avatars.githubusercontent.com/u/3335181?v=4","contributions":["bug","ideas"],"login":"JoshuaKGoldberg","name":"Josh Goldberg","profile":"http://www.joshuakgoldberg.com"}],"contributorsPerLine":7,"contributorsSortAlphabetically":true,"files":["README.md"],"imageSize":100,"projectName":"test-repository","projectOwner":"test-owner","repoHost":"https://github.com","repoType":"github"}",
91+
".all-contributorsrc": "{"badgeTemplate":"\\t<a href=\\"#contributors\\" target=\\"_blank\\"><img alt=\\"👪 All Contributors: <%= contributors.length %>\\" src=\\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\\" /></a>","contributors":[{"avatar_url":"https://avatars.githubusercontent.com/u/3335181?v=4","contributions":["bug","ideas"],"login":"JoshuaKGoldberg","name":"Josh Goldberg","profile":"http://www.joshuakgoldberg.com"}],"contributorsSortAlphabetically":true,"projectName":"test-repository","projectOwner":"test-owner"}",
9292
".github": {
9393
"workflows": {
9494
"contributors.yml": "jobs:

‎src/next/blocks/blockAllContributors.ts

-8
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,10 @@ export const blockAllContributors = base.createBlock({
1818
".all-contributorsrc": JSON.stringify({
1919
badgeTemplate:
2020
' <a href="#contributors" target="_blank"><img alt="👪 All Contributors: <%= contributors.length %>" src="https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg" /></a>',
21-
commit: false,
22-
commitConvention: "angular",
23-
commitType: "docs",
2421
contributors: options.contributors ?? [],
25-
contributorsPerLine: 7,
2622
contributorsSortAlphabetically: true,
27-
files: ["README.md"],
28-
imageSize: 100,
2923
projectName: options.repository,
3024
projectOwner: options.owner,
31-
repoHost: "https://github.com",
32-
repoType: "github",
3325
}),
3426
".github": {
3527
workflows: {

‎src/steps/writing/creation/writeAllContributorsRC.ts

-8
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,9 @@ export async function writeAllContributorsRC(options: Options) {
1010
return await formatJson({
1111
badgeTemplate:
1212
' <a href="#contributors" target="_blank"><img alt="👪 All Contributors: <%= contributors.length %>" src="https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg" /></a>',
13-
commit: false,
14-
commitConvention: "angular",
15-
commitType: "docs",
1613
contributors: existing?.contributors ?? [],
17-
contributorsPerLine: 7,
1814
contributorsSortAlphabetically: true,
19-
files: ["README.md"],
20-
imageSize: 100,
2115
projectName: options.repository,
2216
projectOwner: options.owner,
23-
repoHost: "https://github.com",
24-
repoType: "github",
2517
});
2618
}

0 commit comments

Comments
 (0)
Please sign in to comment.