Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Unnecessary default values in .all-contributorsrc files #1783

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 20, 2024 · 1 comment · Fixed by #1784
Closed
3 tasks done

🐛 Bug: Unnecessary default values in .all-contributorsrc files #1783

JoshuaKGoldberg opened this issue Dec 20, 2024 · 1 comment · Fixed by #1784
Assignees
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

For config files like .all-contributorsrc, only settings that change from defaults should be declared. Anything that's === the default should be omitted.

Actual

I'm pretty sure there are some redundant additions in the current .allcontributorsrc per the docs. I'm looking at at least:

  • commmit
  • commitConvention
  • commitType (which doesn't exist on the docs?)

Additional Info

💖

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 20, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 20, 2024
Copy link

🎉 This is included in version v1.77.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
1 participant