feat: remove eslint-plugin-no-only-tests (#1297)

<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #1294
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Remove eslint-plugin-no-only-tests according to 

<img width="690" alt="Screenshot of --allowOnly description in Vitest
docs"
src="https://github.com/JoshuaKGoldberg/create-typescript-app/assets/95881717/511ba5ce-57b2-4ffa-a938-e9d204071298">

https://vitest.dev/guide/cli#options

---

@JoshuaKGoldberg Should we explain somewhere that it is checked by
vitest?

---------

Co-authored-by: Josh Goldberg ✨ <[email protected]>

Author: DemianParkhomenko

.eslintrc.cjs

@@ -149,7 +149,6 @@ module.exports = {
 		"@typescript-eslint",
 		"deprecation",
 		"jsdoc",
-		"no-only-tests",
 		"perfectionist",
 		"regexp",
 		"vitest",
@@ -159,7 +158,6 @@ module.exports = {
 	rules: {
 		// These off/less-strict-by-default rules work well for this repo and we like them on.
 		"@typescript-eslint/no-unused-vars": ["error", { caughtErrors: "all" }],
-		"no-only-tests/no-only-tests": "error",
 
 		// These on-by-default rules don't work well for this repo and we like them off.
 		"no-case-declarations": "off",

docs/Tooling.md

@@ -194,7 +194,6 @@ pnpm run lint:knip
 Additionally:
 
 - [`console-fail-test`](https://github.com/JoshuaKGoldberg/console-fail-test) will also be added to ensure tests don't accidentally log to the console.
-- [`eslint-plugin-no-only-tests`](https://github.com/levibuzolic/eslint-plugin-no-only-tests) will be added to the ESLint config to ensure calls to `it.only` or similar are not checked in
 - [`eslint-plugin-vitest`](https://github.com/veritem/eslint-plugin-vitest) will be added to the ESLint config to lint for Vitest-specific issues
 
 Running tests in watch mode:

package.json

@@ -78,7 +78,6 @@
 		"eslint-plugin-jsonc": "^2.10.0",
 		"eslint-plugin-markdown": "^3.0.1",
 		"eslint-plugin-n": "^16.3.1",
-		"eslint-plugin-no-only-tests": "^3.1.0",
 		"eslint-plugin-package-json": "^0.10.0",
 		"eslint-plugin-perfectionist": "^2.5.0",
 		"eslint-plugin-regexp": "^2.1.2",

pnpm-lock.yaml

@@ -38,7 +38,7 @@ describe("finalize", () => {
 		expect(mockExecaCommand.mock.calls).toMatchInlineSnapshot(`
 			[
 			  [
-			    "pnpm add @release-it/conventional-changelog@latest @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest @vitest/coverage-v8@latest all-contributors-cli@latest console-fail-test@latest cspell@latest eslint@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-jsdoc@latest eslint-plugin-jsonc@latest eslint-plugin-markdown@latest eslint-plugin-n@latest eslint-plugin-no-only-tests@latest eslint-plugin-package-json@latest eslint-plugin-perfectionist@latest eslint-plugin-regexp@latest eslint-plugin-vitest@latest eslint-plugin-yml@latest husky@latest jsonc-eslint-parser@latest knip@latest lint-staged@latest markdownlint@latest markdownlint-cli@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest release-it@latest sentences-per-line@latest tsup@latest typescript@latest vitest@latest yaml-eslint-parser@latest -D",
+			    "pnpm add @release-it/conventional-changelog@latest @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest @vitest/coverage-v8@latest all-contributors-cli@latest console-fail-test@latest cspell@latest eslint@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-jsdoc@latest eslint-plugin-jsonc@latest eslint-plugin-markdown@latest eslint-plugin-n@latest eslint-plugin-package-json@latest eslint-plugin-perfectionist@latest eslint-plugin-regexp@latest eslint-plugin-vitest@latest eslint-plugin-yml@latest husky@latest jsonc-eslint-parser@latest knip@latest lint-staged@latest markdownlint@latest markdownlint-cli@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest release-it@latest sentences-per-line@latest tsup@latest typescript@latest vitest@latest yaml-eslint-parser@latest -D",
 			  ],
 			  [
 			    "npx all-contributors-cli generate",
@@ -59,7 +59,7 @@ describe("finalize", () => {
 		expect(mockExecaCommand.mock.calls).toMatchInlineSnapshot(`
 			[
 			  [
-			    "pnpm add @release-it/conventional-changelog@latest @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest @vitest/coverage-v8@latest all-contributors-cli@latest console-fail-test@latest cspell@latest eslint@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-jsdoc@latest eslint-plugin-jsonc@latest eslint-plugin-markdown@latest eslint-plugin-n@latest eslint-plugin-no-only-tests@latest eslint-plugin-package-json@latest eslint-plugin-perfectionist@latest eslint-plugin-regexp@latest eslint-plugin-vitest@latest eslint-plugin-yml@latest husky@latest jsonc-eslint-parser@latest knip@latest lint-staged@latest markdownlint@latest markdownlint-cli@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest release-it@latest sentences-per-line@latest tsup@latest typescript@latest vitest@latest yaml-eslint-parser@latest -D --offline",
+			    "pnpm add @release-it/conventional-changelog@latest @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest @vitest/coverage-v8@latest all-contributors-cli@latest console-fail-test@latest cspell@latest eslint@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-jsdoc@latest eslint-plugin-jsonc@latest eslint-plugin-markdown@latest eslint-plugin-n@latest eslint-plugin-package-json@latest eslint-plugin-perfectionist@latest eslint-plugin-regexp@latest eslint-plugin-vitest@latest eslint-plugin-yml@latest husky@latest jsonc-eslint-parser@latest knip@latest lint-staged@latest markdownlint@latest markdownlint-cli@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest release-it@latest sentences-per-line@latest tsup@latest typescript@latest vitest@latest yaml-eslint-parser@latest -D --offline",
 			  ],
 			  [
 			    "npx all-contributors-cli generate",

src/steps/finalizeDependencies.test.ts

@@ -51,7 +51,6 @@ export async function finalizeDependencies(options: Options) {
 			: [
 					"@vitest/coverage-v8",
 					"console-fail-test",
-					"eslint-plugin-no-only-tests",
 					"eslint-plugin-vitest",
 					"vitest",
 			  ]),

src/steps/finalizeDependencies.ts

@@ -237,7 +237,6 @@ describe("createESLintRC", () => {
 				    "@typescript-eslint",
 				    "deprecation",
 				    "jsdoc",
-				    "no-only-tests",
 				    "perfectionist",
 				    "regexp",
 				    "vitest",
@@ -247,7 +246,6 @@ describe("createESLintRC", () => {
 				  rules: {
 				    // These off/less-strict-by-default rules work well for this repo and we like them on.
 				    "@typescript-eslint/no-unused-vars": ["error", { caughtErrors: "all" }],
-				    "no-only-tests/no-only-tests": "error",
 
 				    // These on-by-default rules don't work well for this repo and we like them off.
 				    "no-case-declarations": "off",

src/steps/writing/creation/createESLintRC.test.ts

@@ -200,19 +200,15 @@ module.exports = {
 				? ""
 				: `"jsdoc",
 		`
-		}${options.excludeTests ? "" : `"no-only-tests",`}${
-			options.excludeLintPerfectionist ? "" : `"perfectionist",`
-		}${options.excludeLintRegex ? "" : `"regexp",`}${
-			options.excludeTests ? "" : `\n"vitest",`
-		}
+		}${options.excludeLintPerfectionist ? "" : `"perfectionist",`}${
+			options.excludeLintRegex ? "" : `"regexp",`
+		}${options.excludeTests ? "" : `\n"vitest",`}
 	],
 	reportUnusedDisableDirectives: true,
 	root: true,
 	rules: {
 		// These off/less-strict-by-default rules work well for this repo and we like them on.
-		"@typescript-eslint/no-unused-vars": ["error", { caughtErrors: "all" }],${
-			options.excludeTests ? "" : `\n"no-only-tests/no-only-tests": "error",`
-		}
+		"@typescript-eslint/no-unused-vars": ["error", { caughtErrors: "all" }],
 
 		// These on-by-default rules don't work well for this repo and we like them off.
 		"no-case-declarations": "off",