feat: remove eslint-plugin-no-only-tests

[DemianParkhomenko]

PR Checklist

• Addresses an existing open issue: fixes 🛠 Tooling: Remove eslint-plugin-no-only-tests #1294
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Remove eslint-plugin-no-only-tests according to

https://vitest.dev/guide/cli#options

---

@JoshuaKGoldberg Should we explain somewhere that it is checked by vitest?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ea1c18) 94.79% compared to head (f449f66) 94.78%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
- Coverage   94.79%   94.78%   -0.01%     
==========================================
  Files         103      103              
  Lines        5781     5776       -5     
  Branches      490      488       -2     
==========================================
- Hits         5480     5475       -5     
  Misses        300      300              
  Partials        1        1              

Flag	Coverage Δ
create	69.94% <25.00%> (+<0.01%)	⬆️
initialize	42.44% <0.00%> (+0.03%)	⬆️
migrate	69.86% <25.00%> (+0.02%)	⬆️
unit	75.64% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JoshuaKGoldberg]

LGTM, thanks! 🚀

Some unrelated build failures, and I think just one small newline touchup. I'm excited about this and can just apply it myself.

[JoshuaKGoldberg]

@JoshuaKGoldberg Should we explain somewhere that it is checked by vitest?

Nah, I think we're fine not to. It's a pretty rare thing for someone to do except when testing code out. If folks do accidentally leave it in, the Vitest failure is pretty clear. Good question!

[JoshuaKGoldberg]

The migration test failure is unrelated flake (grr).

For the accessibility bot, you'll want to always provide alt text for informative issues. Otherwise users who can't visually see the image won't know what's in it. https://github.com/github/accessibility-alt-text-bot has more info.

The code change looks great, thanks!

[JoshuaKGoldberg]

🚢

[JoshuaKGoldberg]

@all-contributors please add @DemianParkhomenko for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

[allcontributors]

@JoshuaKGoldberg

I've put up a pull request to add @DemianParkhomenko! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

[github-actions]

🎉 This is included in version v1.57.0 🎉

The release is available on:

• GitHub releases
• npm package (@latest dist-tag)

Cheers! 📦🚀