Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: JoshuaKGoldberg/create-typescript-app
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.67.1
Choose a base ref
...
head repository: JoshuaKGoldberg/create-typescript-app
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.67.2
Choose a head ref
  • 2 commits
  • 6 files changed
  • 2 contributors

Commits on Aug 11, 2024

  1. fix: run pnpm dedupe --offline in cleanups (#1611) 

    ## PR Checklist

- [x] Addresses an existing open issue: fixes #1610
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Doesn't impact `pnpm lint:packages`, just the migration/setup scripts.

💖
    @JoshuaKGoldberg
    JoshuaKGoldberg authored Aug 11, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    e680691 View commit details

  2. chore: release v1.67.2

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Aug 11, 2024
    Copy the full SHA
    ebc96fa View commit details
Showing with 13 additions and 7 deletions.
  1. +6 −0 CHANGELOG.md
  2. +1 −1 package.json
  3. +1 −1 src/shared/createCleanupCommands.test.ts
  4. +1 −1 src/shared/createCleanupCommands.ts
  5. +3 −3 src/steps/finalizeDependencies.test.ts
  6. +1 −1 src/steps/finalizeDependencies.ts
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## [1.67.2](https://github.com/JoshuaKGoldberg/create-typescript-app/compare/v1.67.1...v1.67.2) (2024-08-11)

### Bug Fixes

- run pnpm dedupe --offline in cleanups ([#1611](https://github.com/JoshuaKGoldberg/create-typescript-app/issues/1611)) ([e680691](https://github.com/JoshuaKGoldberg/create-typescript-app/commit/e68069108ea3a3c7779399946e373b203bd91e8a)), closes [#1610](https://github.com/JoshuaKGoldberg/create-typescript-app/issues/1610)

## [1.67.1](https://github.com/JoshuaKGoldberg/create-typescript-app/compare/v1.67.0...v1.67.1) (2024-08-11)

### Bug Fixes
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "create-typescript-app",
"version": "1.67.1",
"version": "1.67.2",
"description": "Quickstart-friendly TypeScript template with comprehensive, configurable, opinionated tooling. 💝",
"repository": {
"type": "git",
2 changes: 1 addition & 1 deletion src/shared/createCleanupCommands.test.ts
View file
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ describe("createCleanupCommands", () => {
});

expect(actual).toEqual([
"pnpm dedupe",
"pnpm dedupe --offline",
"pnpm build",
"pnpm lint --fix",
"pnpm format --write",
2 changes: 1 addition & 1 deletion src/shared/createCleanupCommands.ts
View file
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ export function createCleanupCommands({
}: Pick<Options, "bin" | "mode">) {
return [
// There's no need to dedupe when initializing from the fixed template
...(mode === "initialize" ? [] : ["pnpm dedupe"]),
...(mode === "initialize" ? [] : ["pnpm dedupe --offline"]),
// n/no-missing-import rightfully reports on a missing the bin .js file
...(bin ? ["pnpm build"] : []),
"pnpm lint --fix",
6 changes: 3 additions & 3 deletions src/steps/finalizeDependencies.test.ts
View file
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@ describe("finalize", () => {
"npx all-contributors-cli generate",
],
[
"pnpm dedupe",
"pnpm dedupe --offline",
],
]
`);
@@ -65,7 +65,7 @@ describe("finalize", () => {
"npx all-contributors-cli generate",
],
[
"pnpm dedupe",
"pnpm dedupe --offline",
],
]
`);
@@ -95,7 +95,7 @@ describe("finalize", () => {
"pnpm add @eslint-community/eslint-plugin-eslint-comments@latest @eslint/js@latest @types/eslint-plugin-markdown@latest @types/eslint__js@latest @types/node@latest eslint@latest eslint-plugin-jsdoc@latest eslint-plugin-n@latest eslint-plugin-regexp@latest husky@latest lint-staged@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest prettier-plugin-sh@latest tsup@latest typescript@latest typescript-eslint@latest -D",
],
[
"pnpm dedupe",
"pnpm dedupe --offline",
],
]
`);
2 changes: 1 addition & 1 deletion src/steps/finalizeDependencies.ts
View file
Original file line number Diff line number Diff line change
@@ -73,5 +73,5 @@ export async function finalizeDependencies(options: Options) {
);
}

await execaCommand(`pnpm dedupe`);
await execaCommand(`pnpm dedupe --offline`);
}