Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: If a withSpinners step rejects, lines are still written continuously #1016

Closed
3 tasks done
JoshuaKGoldberg opened this issue Nov 11, 2023 · 1 comment · Fixed by #1017
Closed
3 tasks done

🐛 Bug: If a withSpinners step rejects, lines are still written continuously #1016

JoshuaKGoldberg opened this issue Nov 11, 2023 · 1 comment · Fixed by #1017
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Crashes such as those in #1015 should stop the terminal altogether.

Actual

│
◇  Do you want to restore the repository to how it was?
│  Yes
│
│  Resetting repository using git restore .
│
●  Tip: to run again with the same input values, use: npx create-typescript-app --mode migrate --base minimum --access public --author JoshuaKGoldberg --description "Rules for consistent, readable, and valid package.json files. 🗂️" --directory eslint-plugin-package-json --email-github [email protected] --email-npm [email protected] --mode migrate --owner JoshuaKGoldberg --repository eslint-plugin-package-json --title eslint-plugin-package-json
│
└  Operation cancelled. Exiting - maybe another time? 👋

│   - Updating local files
│   - Updating local files.
│   - Updating local files..
│   - Updating local files...

...and so on.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Nov 11, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Nov 11, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 11, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Nov 11, 2023
@JoshuaKGoldberg
fix: graceful recovery for failed spinner step (#1017)
e36f765 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1016
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Moves the recovery pieces of the `withSpinners` loop into a `finally` so
they always get called.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.43.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: graceful recovery for failed spinner step JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg