Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add .eslint to deleted unnecessary files #1018

Closed
3 tasks done
JoshuaKGoldberg opened this issue Nov 11, 2023 · 1 comment · Fixed by #1052
Closed
3 tasks done

🚀 Feature: Add .eslint to deleted unnecessary files #1018

JoshuaKGoldberg opened this issue Nov 11, 2023 · 1 comment · Fixed by #1052
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, https://github.com/JoshuaKGoldberg/create-typescript-app/blob/860c5b3c06ba330b9e341a6cc8651cfe81bf61fc/src/steps/clearUnnecessaryFiles.ts contains logic to delete unnecessary files upon migrating an existing repository. It's used within --mode migrate.

I noticed that https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/a382e96a54f91a3da6ae6f2c4f7e0ddd973c3239/.eslintrc wasn't deleted when I ran the migration mode on that repository. But .eslint files should be removed. Let's add it to the list of globPaths that get deleted! 🔪

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Nov 11, 2023
@jaas666 jaas666 mentioned this issue Nov 23, 2023
Merged
3 tasks
JoshuaKGoldberg pushed a commit that referenced this issue Nov 24, 2023
@jaas666
feat: Add .eslintrc to clearUnnecessaryFiles.ts (#1052)
d785711 
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [X] Addresses an existing open issue: fixes #1018 
- [X] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [X] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview
Adds `.eslintrc` to the list of files deleted by
`clearUnnecessaryFiles.ts`
<!-- Description of what is changed and how the code change does that.
-->
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.47.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add .eslintrc to clearUnnecessaryFiles.ts
1 participant
@JoshuaKGoldberg