Skip to content

🐛 Bug: --owner and --description are no longer factored into defaults #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 7, 2023 · 1 comment · Fixed by #1084
Closed
3 tasks done

🐛 Bug: --owner and --description are no longer factored into defaults #1083

JoshuaKGoldberg opened this issue Dec 7, 2023 · 1 comment · Fixed by #1084
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Running npx create-typescript-app --owner MyUsername should populate the default value for the CLI's owner value.

Actual

I broke this in #1046. It's no longer respected. Note how options.owner isn't provided to the getPrefillOrPromptedOption function, so it won't show up in the suggested placeholder:

create-typescript-app/src/shared/options/readOptions.ts

Lines 125 to 132 in 21c8529

const ownerOption = await getPrefillOrPromptedOption(
"owner",
!!mappedOptions.auto,
"What organization or user will the repository be under?",
defaults.owner,
);
options.owner ??= ownerOption.value;

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 7, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 7, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 7, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Dec 7, 2023
@JoshuaKGoldberg
fix: corrected readOptions using provided values (#1084)
b3c7970 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1083
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Prepends `options.owner` in front of the default value getter. Same with
other options values.

The unit test doesn't quite catch this specific addition but I'm annoyed
at how convoluted `readOptions` has gotten...
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

🎉 This is included in version v1.49.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: corrected readOptions using provided values JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg