Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrected readOptions using provided values #1084

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 7, 2023

PR Checklist

Overview

Prepends options.owner in front of the default value getter. Same with other options values.

The unit test doesn't quite catch this specific addition but I'm annoyed at how convoluted readOptions has gotten...

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c3f93db) 94.20% compared to head (a458ed2) 94.18%.

Files Patch % Lines
src/shared/options/readOptions.ts 91.30% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
- Coverage   94.20%   94.18%   -0.03%     
==========================================
  Files          97       97              
  Lines        5608     5620      +12     
  Branches      454      457       +3     
==========================================
+ Hits         5283     5293      +10     
- Misses        324      326       +2     
  Partials        1        1              
Flag Coverage Δ
create 70.24% <61.01%> (-0.14%) ⬇️
initialize 42.15% <61.01%> (-0.06%) ⬇️
migrate 69.58% <61.01%> (-0.21%) ⬇️
unit 72.15% <86.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit b3c7970 into main Dec 7, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix-read-options-provided branch December 7, 2023 20:14
Copy link

github-actions bot commented Dec 7, 2023

🎉 This is included in version v1.49.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: --owner and --description are no longer factored into defaults
1 participant