Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: npx create-typescript-app doesn't prompt for description or title #1106

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 22, 2023 · 1 comment · Fixed by #1107
Closed
3 tasks done
Assignees
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

When running with npx, the following fields should be prompted if not explicitly provided:

  • title
  • description
  • repository
  • owner

Actual

Seems like description and title are going with defaults...

npx create-typescript-app --mode create
┌  ✨ Welcome to create-typescript-app 1.49.2! ✨
│
│  ⚠️ This template is early stage, opinionated, and not endorsed by the TypeScript team. ⚠️
│  ⚠️ If any tooling it sets displeases you, you can always remove that portion manually. ⚠️
│
◇  What organization or user will the repository be under?
│  JoshuaKGoldberg
│
◇  What will the kebab-case name of the repository be?
│  github-username-to-emails
│
◇  ✅ Passed checking GitHub authentication.
│
◇  How much tooling would you like the template to set up for you?
│  everything	 The most comprehensive tooling imaginable: sorting, spellchecking, and more!
│
◇  ✅ Passed creating repository structure.
│
◇  ✅ Passed adding contributors to table.
│
◇  ✅ Passed installing packages.
│
◇  ✅ Passed cleaning up files.
│
◇  ✅ Passed initializing GitHub repository.
│
└  Great, looks like the script finished! 🎉

Be sure to:

- enable the GitHub apps:
   - Codecov (https://github.com/apps/codecov)
   - Renovate (https://github.com/apps/renovate)
- populate the secrets:
   - ACCESS_TOKEN (a GitHub PAT with repo and workflow permissions)
   - NPM_TOKEN (an npm access token with automation permissions)

See ya! 👋

│
●  Tip: to run again with the same input values, use: npx create-typescript-app --mode create --access public --description "A very lovely package. Hooray!" --directory github-username-to-emails --email-github [email protected] --email-npm [email protected] --mode create --owner JoshuaKGoldberg --repository github-username-to-emails --title "Github Username to Emails"

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 22, 2023
JoshuaKGoldberg added a commit that referenced this issue Dec 22, 2023
#1107)

## PR Checklist

- [x] Addresses an existing open issue: fixes #1106
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

A default value being present for `getPrefillOrPromptedValue` doesn't
mean it should be used. Only a _provided_ value does. This adds an
explicit `provided?: string` to the function's options.
Copy link

🎉 This is included in version v1.49.3 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
1 participant