Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prompt for values when auto is off, regardless of a default value #1107

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 22, 2023

PR Checklist

Overview

A default value being present for getPrefillOrPromptedValue doesn't mean it should be used. Only a provided value does. This adds an explicit provided?: string to the function's options.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7198e6) 94.18% compared to head (39760e1) 94.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
+ Coverage   94.18%   94.25%   +0.07%     
==========================================
  Files          97       97              
  Lines        5620     5625       +5     
  Branches      457      454       -3     
==========================================
+ Hits         5293     5302       +9     
+ Misses        326      322       -4     
  Partials        1        1              
Flag Coverage Δ
create 70.21% <66.66%> (-0.03%) ⬇️
initialize 42.15% <66.66%> (-0.01%) ⬇️
migrate 69.55% <66.66%> (-0.03%) ⬇️
unit 72.31% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 127108f into main Dec 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the defaults-prompt-manual branch December 22, 2023 03:32
Copy link

🎉 This is included in version v1.49.3 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: npx create-typescript-app doesn't prompt for description or title
1 participant