Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Investigate simplifying release commenter version name #1115

Open
3 tasks done
JoshuaKGoldberg opened this issue Dec 26, 2023 · 4 comments · Fixed by #1663 or #1665
Open
3 tasks done

🛠 Tooling: Investigate simplifying release commenter version name #1115

JoshuaKGoldberg opened this issue Dec 26, 2023 · 4 comments · Fixed by #1663 or #1665
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Following #427 -> #428: per apexskier/github-release-commenter#432, it looks like ${{ payload.release.tag_name }} should be usable to get the tag name of the released version. It'd be nice to use that instead of having to manually run a command:

create-typescript-app/.github/workflows/post-release.yml

Line 8 in d53c4ee

- run: echo "npm_version=$(npm pkg get version | tr -d '"')" >> "$GITHUB_ENV"

Investigation required. If this strategy does work, hooray! Accepting PRs!

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: needs investigation Further research required...? labels Dec 26, 2023
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! and removed status: needs investigation Further research required...? labels Aug 10, 2024
@JoshuaKGoldberg JoshuaKGoldberg removed this from the General Simplification milestone Aug 10, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 17, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.73.1 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg
Copy link
Owner Author

Ah, wrong link. Will fix.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 17, 2024
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Owner Author

I really hate debugging GitHub Actions...


Invalid workflow file: .github/workflows/post-release.yml#L11The workflow is not valid. .github/workflows/post-release.yml (Line: 11, Col: 29): Unrecognized named-value: 'payload'. Located at position 1 within expression: payload.release.tag_name
--


[Invalid workflow file: .github/workflows/post-release.yml#L11](https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/11394888134/workflow)
The workflow is not valid. .github/workflows/post-release.yml (Line: 11, Col: 29): Unrecognized named-value: 'payload'. Located at position 1 within expression: payload.release.tag_name

@JoshuaKGoldberg
Copy link
Owner Author

Things are back to how they were in #1666. Still accepting PRs on this issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
1 participant
@JoshuaKGoldberg