Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Release bot posts invalid npm and GitHub releases links #427

Closed
3 tasks done
JoshuaKGoldberg opened this issue May 12, 2023 · 2 comments · Fixed by #428
Closed
3 tasks done

🐛 Bug: Release bot posts invalid npm and GitHub releases links #427

JoshuaKGoldberg opened this issue May 12, 2023 · 2 comments · Fixed by #428
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

As of #421 + f2434ab, the release bot is posting comments with links to npm & GitHub releases on issues and PRs. Those links should work...

Actual

...but they're 404s right now: #401 (comment)

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels May 12, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this May 12, 2023
This was referenced May 13, 2023
Closed
Merged
JoshuaKGoldberg added a commit that referenced this issue May 13, 2023
@JoshuaKGoldberg
fix: use npm pkg version in post-release (#428)
8bd5c1c 
## PR Checklist

- [x] Addresses an existing open issue: fixes #427
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Uses `npm pkg get version` to set the npm version in an `npm_version`
env variable per
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable.
Then uses it in the comment template.
@github-actions
Copy link

🎉 This is included in version v1.27.81 🎉

The release is available on:

Cheers! 📦🚀

1 similar comment
@github-actions
Copy link

🎉 This is included in version v1.27.81 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue May 13, 2023
Closed
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 26, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use npm pkg version in post-release JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg