Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Re-run command includes unnecessary true value for boolean options #1129

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 29, 2023 · 2 comments · Fixed by #1144
Closed
3 tasks done

🐛 Bug: Re-run command includes unnecessary true value for boolean options #1129

JoshuaKGoldberg opened this issue Dec 29, 2023 · 2 comments · Fixed by #1144
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 29, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

The re-run command when you cancel or complete npx create-typescript-app should be as minimal as possible. Boolean options set to true, such as offline, can just be --offline. No need for --offline true. They mean the same thing.

Actual

Alas, the rerun suggestion does print --offline true and similar:

npx create-typescript-app --mode create --offline
┌  ✨ Welcome to create-typescript-app 1.50.0! ✨
│
│  ⚠️ This template is early stage, opinionated, and not endorsed by the TypeScript team. ⚠️
│  ⚠️ If any tooling it sets displeases you, you can always remove that portion manually. ⚠️
│
■  What organization or user will the repository be under?
│
│
●  Tip: to run again with the same input values, use: npx create-typescript-app --mode undefined --offline true --skip-all-contributors-api true --skip-github-api true
│
└  Operation cancelled. Exiting - maybe another time? 👋

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 29, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 29, 2023
Closed
3 tasks
@DerTimonius
Copy link
Contributor

I will look into it! 🙂

@DerTimonius DerTimonius mentioned this issue Dec 30, 2023
Merged
3 tasks
JoshuaKGoldberg pushed a commit that referenced this issue Dec 30, 2023
@DerTimonius
fix: remove unnecessary boolean values in rerun suggestions (#1144)
e560bfc 
## PR Checklist

- [X] Addresses an existing open issue: fixes #1129 
- [X] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [X] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

This PR fixes an issue in the rerun suggestions, where `true` is
unnecessarily being printed. This change leads to the following:

```shell
# previous
npx create-typescript-app --mode create --skip-install true

# new
npx create-typescript-app --mode create --skip-install
```

The related tests have also been changed.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.50.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove unnecessary boolean values in rerun suggestions DerTimonius/create-typescript-app
2 participants
@JoshuaKGoldberg @DerTimonius