Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary boolean values in rerun suggestions #1144

Conversation

DerTimonius
Copy link
Contributor

PR Checklist

Overview

This PR fixes an issue in the rerun suggestions, where true is unnecessarily being printed. This change leads to the following:

# previous
npx create-typescript-app --mode create --skip-install true

# new
npx create-typescript-app --mode create --skip-install

The related tests have also been changed.

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d48fee) 94.27% compared to head (7dfa4b9) 94.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1144   +/-   ##
=======================================
  Coverage   94.27%   94.28%           
=======================================
  Files          97       97           
  Lines        5627     5631    +4     
  Branches      455      457    +2     
=======================================
+ Hits         5305     5309    +4     
  Misses        321      321           
  Partials        1        1           
Flag Coverage Δ
create 70.24% <100.00%> (+0.02%) ⬆️
initialize 42.20% <100.00%> (+0.04%) ⬆️
migrate 69.63% <100.00%> (+0.02%) ⬆️
unit 72.32% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigourney Weaver in business-y attire saying 'perfect'

@JoshuaKGoldberg JoshuaKGoldberg merged commit e560bfc into JoshuaKGoldberg:main Dec 30, 2023
Copy link

🎉 This is included in version v1.50.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Re-run command includes unnecessary true value for boolean options
2 participants