Skip to content

🐛 Bug: Two README.md badges are showing as invalid images #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 31, 2023 · 1 comment · Fixed by #1156
Closed
3 tasks done

🐛 Bug: Two README.md badges are showing as invalid images #1155

JoshuaKGoldberg opened this issue Dec 31, 2023 · 1 comment · Fixed by #1156
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 31, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

README.md image badges should be images.

Actual

Screenshot of the README.md image badges, where all but the coverage and npm version ones are valid images

Original: https://img.shields.io/codecov/c/github/JoshuaKGoldberg/create-typescript-app?label=🧪%20coverage

GitHub-hosted: https://camo.githubusercontent.com/0bbb37a37db3051cfcfc44b617d0cbca4a69bef052a8b30a5a79445654d407cd/68747470733a2f2f696d672e736869656c64732e696f2f6e706d2f762f6372656174652d747970657363726970742d6170703f636f6c6f723d323162623432266c6162656c3df09f93a62532306e706d

The original image URLs are fine but these githubusercontent ones are giving Invalid upstream response (520). ?!

Additional Info

They were working when I used them in #1154.
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 31, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🐛 Bug: Two README.md badges are showing as invalid mimages 🐛 Bug: Two README.md badges are showing as invalid images Dec 31, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 31, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Dec 31, 2023
@JoshuaKGoldberg
fix: encode emojis in README.md badge images (#1156)
378d1b0 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1155
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

For each README.md image badge, I:

1. Copied the image into Chrome's URL bar -> it stayed the same
2. Copied the url into VS Code -> it became encoded like this

🤷 maybe this won't trip the same GitHub-side bug seen in 1155?
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.52.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: encode emojis in README.md badge images JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg